Project

General

Profile

Actions
Copy link

Emulator Issues #8261

closed

Core/Core/HW/BBA-TAP/TAP_Win32.cpp - GetGUIDs() returns false if it finds any improperly configured connection

Added by tmo7452 about 9 years ago. Updated about 1 month ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
4.0-7214

Description

Core/Core/HW/BBA-TAP/TAP_Win32.cpp
GetGUIDs() contains multiple

if (status != ERROR_SUCCESS)
return false;

checks inside the while loop (lines 114, 130), these should be changed to "continue;" instead of "return false;".

In my situation, VirtualBox creates a connection that does not have a "Name" value, when GetGUIDs() encounters this connection, it aborts the entire search and CEXIETHERNET::Activate() logs "Failed to find a TAP GUID" then returns false, despite the fact that GetGUIDs already found a valid TAP adapter.

Actions
Copy link

Also available in: Atom PDF