Project

General

Profile

Emulator Issues #8307

Hotkey fixes #2010 causes gcpad profiles not to load per game in the gameinis anymore.

Added by kostamarino over 5 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What's the problem? Describe what went wrong in few words.
Gcpad profiles do not load per game in the gameinis anymore.

What did you expect to happen instead?
For gcpad profiles to load when:
[Controls]
PadProfile1 = Profile_name_here
to load when set in the gameini.

What steps will reproduce the problem?
[Don't assume we have ever played the game and know any level names. Be as
specific as possible.]
1.Create a gc pad profile for pad 1 and save it.
2.Put:
[Controls]
PadProfile1 = Profile_name_here
in a gamecube game ini and then load the said game.
3. Your profile won't load

Dolphin 3.5 and 3.5-367 are old versions of Dolphin that have
known issues and bugs, so don't report issues about them and test the
latest Dolphin version first.
Which versions of Dolphin did you test on?
Dolphin-x64-v40-5710, dolphin-master-4.0-5406-x64

Does using an older version of Dolphin solve your issue? If yes, which
versions of Dolphin used to work?
Yes, dolphin-master-4.0-5402-x64

Here is a link to the offending commit: https://github.com/dolphin-emu/dolphin/pull/2010

History

#1 Updated by kostamarino over 5 years ago

  • Status changed from New to Accepted

#2 Updated by skidau over 5 years ago

  • Status changed from Accepted to Work started

Seems to be fixed in PR2011:

https://github.com/dolphin-emu/dolphin/pull/2011

Download a test build here:

http://dl.dolphin-emu.org/prs/pr-2011-dolphin-latest-x64.7z

Let me know if it works for you.

#3 Updated by kostamarino over 5 years ago

  • Status changed from Work started to Fix pending

Seems fixed here too :-).

#4 Updated by skidau over 5 years ago

  • Status changed from Fix pending to Fixed

#5 Updated by Bearborg over 5 years ago

This issue is fixed for Gamecube controllers, but it's still broken for Wiimotes.

#6 Updated by kostamarino over 5 years ago

Wiimote profiles worked before, something got broken in this pr it seems, i also have problems entering and exiting fullscreen while i didn't when i initially tested.

#7 Updated by kostamarino over 5 years ago

  • Status changed from Fixed to Accepted

Reopening this since now wiimote profiles got broken and hotkeys like alt+enter have issues after PR2011 was merged.

#8 Updated by skidau over 5 years ago

I have tested the full screen hotkey and key shortcut and they both work with and without render to main on both gamecube and wii games. I suggest that you clear the hotkey for full screen (and maybe clear all of the hotkeys) and use the key shortcuts unless you want to specifically map a gamepad button to a hotkey.

I will check the wiimote profile function.

#9 Updated by skidau over 5 years ago

The wiimote profile problem is a copy and paste error and is fixed in PR2190.

https://github.com/dolphin-emu/dolphin/pull/2190

Test build:
http://dl.dolphin-emu.org/prs/pr-2190-dolphin-latest-x64.7z

#10 Updated by Bearborg over 5 years ago

Yep, that fixes it for me.

#11 Updated by skidau over 5 years ago

  • Status changed from Accepted to Fixed

Also available in: Atom PDF