Project

General

Profile

Actions

Emulator Issues #8318

closed

Zelda Twilight gives read error upon loading a save on newest versions

Added by 2tailedfox about 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

[READ THIS: https://forums.dolphin-emu.org/showthread.php?pid=276132 <<<
Your answers are there!]
[Leave the questions as they are and answer them in the next line]
[Remove lines written inside brackets [], but nothing else]

Game Name?
The Legend of Zelda: Twilight Princess

Game ID?
RZDE01 rev 2

What's the problem? Describe what went wrong in few words.
Upon loading a save file, but before any graphics load, an error message appears in the format "Invalid Read from to 0x(Hex), PC = 0x(Hex)"
The Hex numbers vary, and when clicking ok, the same message will reappear with a new
couple of hex numbers.
a couple of them are "0x222d447c, PC = 0x8002d6dc" and "0x2400cb18, PC = 0x8002s208"
Happens using opengl or d3d.

What did you expect to happen instead?

What steps will reproduce the problem?
[Don't assume we have ever played the game and know any level names. Be as
specific as possible.]

  1. Start the game
  2. press A+B at title
  3. Load a save file
  4. Error occurs

Dolphin 3.5 and 3.5-367 are old versions of Dolphin that have
known issues and bugs, so don't report issues about them and test the
latest Dolphin version first.
Which versions of Dolphin did you test on?
4.0, 5760 and 5762

Does using an older version of Dolphin solve your issue? If yes, which
versions of Dolphin used to work?
4.0, 5386 works fine, and a newer one that I overwrote did too (not sure which version it was)

What are your PC specifications? (including, but not limited to: Operating
System, CPU and GPU)
Win 7 x64, Radeon hd 7950, i5 5690k, 8gb ddr3 pc1600 ram, dolphin bar, samsung hdtv, denon surround receiver.

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)
[Upload big files to a hosting service and post links here!]

[Do not attach files to this issue. Upload them to another site and
link here. Use imgur.com for images and pastie.org for logs. Monitor the
email address that was used to create this issue.]

Actions #1

Updated by JMC4789 about 9 years ago

Try disabling the Twilight Princess Hack.

Actions #2

Updated by 2tailedfox about 9 years ago

Ok. That works. But basically renders the game unplayable, and does not explain why it worked before but does not work now. What change was made and in what version that broke this?

Actions #3

Updated by JMC4789 about 9 years ago

Well if you find out which build caused the change in behavior, I think that would go a long way in figuring out why it got broken. Try bisecting it down further if you can.

Actions #4

Updated by 2tailedfox about 9 years ago

Alright. After a lot of trial and error, 5692 is the newest which works.
5695 is the first in the list which causes the issue.

Actions #5

Updated by JMC4789 about 9 years ago

It's quite possibly using the wrong Twilight Princess Hack...

Actions #6

Updated by 2tailedfox about 9 years ago

There are 3 listed. I've tried various combinations

Actions #7

Updated by JMC4789 about 9 years ago

There should be 1.0, 1.02 and PAL on there. If they're not labeled, it's failure on our part.

Actions #8

Updated by 2tailedfox about 9 years ago

I am using RZDE01 rev 2

Actions #9

Updated by JMC4789 about 9 years ago

since that change messed with INIs, it's possible that the new INI has a messed up code in it or something, Can you copy the RZDE01 INI from the old build and paste it over the ones in the new build and try that?

Actions #10

Updated by 2tailedfox about 9 years ago

old has one ini file, new has 3.

Actions #11

Updated by 2tailedfox about 9 years ago

Overwritting RZDE01r2.ini with the old files data seems to have fixed it.

Actions #12

Updated by JMC4789 about 9 years ago

  • Status changed from New to Accepted
  • Regression set to Yes
Actions #13

Updated by 2tailedfox about 9 years ago

It seems to slowdown a bit in hyrule field though. They main speed hack is selected. (this is on the latest 5762 with old ini replacing the r6 ini). So I tried changing the options to the v2 speed hack and that causes the initial issue to happen again. Might just be that something else was slowing it down or something, I don't know.

Actions #14

Updated by 2tailedfox about 9 years ago

It was in fact my toying with stereo 3D which caused the slowdown. Sorry.

Actions #15

Updated by JosJuice about 9 years ago

  • Status changed from Accepted to Duplicate

There are three types of game INIs: region-free, region-specific, and revision-specific. Until recently, region-free didn't exist and revision-specific didn't work for anything but GameCube discs. When I overhauled the game INI code a bit to make region-free INIs work, I also made revision-specific INIs work for all games as a side effect. Around the same time, RZDE01.ini was modified to contain two Hyrule Field Speed Hack patches, one for v0 and one for v2, with the v2 one marked with something like "v2 (use this one if the other one doesn't work)". That could be improved from a UX perspective, so in the game INI PR, the v0 code was put in RZDE01r0.ini, the v2 code was put in RZDE01r2.ini, and RZDE.ini was deleted. The only other game that does something like this is GALE01 (SSBM). This made Dolphin automatically detect which revision was used, so that only the relevant patch would be displayed.

...or at least that's what it would be doing if the buildbot had deleted the old INI.

Actions #16

Updated by JosJuice about 9 years ago

Err, I meant that RZDE01.ini was deleted. But you get the point.

Actions #17

Updated by 2tailedfox about 9 years ago

Will this be fixed in a future build?

Actions #18

Updated by 2tailedfox about 9 years ago

Seriously, since it's such an easy fix, why has it not been corrected in any of the newer builds?

Actions #19

Updated by JosJuice about 9 years ago

Just deleting the RZDE01.ini file is simple - I did it at the same time as I added the two new ones. If you pull the git repo, you will see that the issue doesn't exist. The problem is that the buildbot needs to be able to delete files as part of its automated building process in order for the file to be deleted in the dolphin-emu.org builds. Coding a fix for that is more complicated than just deleting a file, and very few people tend to work on the buildbot, because it rarely needs fixing.

Actions #20

Updated by 2tailedfox about 9 years ago

Simply deleting that file does not fix the issue. It seems to be loading the r2 file, but the data in that file is incorrect. What I had done if you read back was replace the text in the RZDE01r2.ini with the text from the old RZDE01.ini file.

Actions #21

Updated by JosJuice about 9 years ago

Yes, I did read back. The RZDE01r2.ini code is identical to the "Hyrule Field Speed Hack v2 by TheWearyGamer (use it if the other one doesn't work)" code in RZDE01.ini, so it should work, but I suppose it's possible that it's mislabeled and the "v2" doesn't refer to revision 2 of the game. Does it work if you rename RZDE01r0.ini to RZDE01r2.ini and vice versa?

Actions #22

Updated by 2tailedfox about 9 years ago

I deleted RZDE01.ini, and then renamed RZDE01r2.ini to RZDE01r3.ini, and renamed RZDE01r0.ini to RZDE01r2.ini. That worked.

Actions #23

Updated by JosJuice about 9 years ago

  • Status changed from Duplicate to Fix pending

Okay, thanks. I've re-opened this issue and submitted a fix. This build should fix your problem, although there will still be too many entries because of RZDE01.ini. http://dl.dolphin-emu.org/prs/pr-2207-dolphin-latest-x64.7z

Actions #24

Updated by 2tailedfox about 9 years ago

Confirmed. The issue is resolved.

Actions #25

Updated by jaspiring about 9 years ago

Guys, it's not fixed. I'm getting that same error. Even with the version JosJuice just linked to. Wasn't a problem before I updated Dolphin earlier today. Luckily I still had 4.0.2 as a backup, and it works in that.

Actions #26

Updated by JosJuice about 9 years ago

If you delete C:\Users<your username>\Documents\Dolphin Emulator\GameSettings\RZDE01.ini, does it work in any of the builds?

Actions #27

Updated by JosJuice about 9 years ago

  • Status changed from Fix pending to Fixed

RZDE01r0.ini and RZDE01r2.ini have now switched places in 4.0-5919. https://dolphin-emu.org/download/dev/d3ccad42c6b52fa6a1105ec3d87c337e49bab6c6/

Actions

Also available in: Atom PDF