Project

General

Profile

Actions

Emulator Issues #8374

closed

Feature request: Automatically change discs for two-disc games

Added by JosJuice almost 10 years ago. Updated almost 6 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Feature request
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-9343

Description

Some GC game loaders for the Wii support automatically changing discs for games that require two discs. For instance, DIOS MIOS added it in r34: https://code.google.com/p/diosmios/source/detail?r=34

It would be convenient to have this feature in Dolphin. According to the diff linked above, it can be done by changing disc when the DI command DVDLowStopMotor is used. This means that we simply can call ChangeDisc(newFileName) in DVDInterface's DVDLowStopMotor case if some "Change disc automatically" option is enabled, but I see two problems with this.

  1. There are cases where DVDLowStopMotor is used but the disc should not be changed. For instance, I think the Wii Menu does it after reading the metadata of a newly inserted disc. Is it okay to expect users to disable the "Change disc automatically" option in situations like launching a 2-disc game from the Wii Menu?

  2. How is DVDInterface supposed to know the filename of the disc to insert? Should the GUI somehow tell it when launching emulation?

Actions #1

Updated by mimimi almost 10 years ago

About 1: Running gamecube games from disc channel does not work in Dolpin. How many 2 disc wii games are there? Is there even one? If there isn't one, i'd suggest to switch only for gamecube games, problem solved.

About 2: It should switch between disc 1 and disc 2. As long as there are not multiple copies, it's clear which disc to insert. If there are multiple copies for the same disc, don't switch the disc. In this case, it's possible a patched and a not patched version are in the list. But since this is really rare, i would not add a GUI option for this.

If you go on about GUI changes, i propose the following:

  • For 2 disc games, show only 1 entry. Maybe add disc 1&2 or something. (only if there's 1 version for each disc, see above)
  • For 2 disc games, where only one disc is present, show something like "disc 1 only"
Actions #2

Updated by JosJuice almost 10 years ago

  1. That's true. (There are no dual-disc Wii games, only dual-layer ones.) I suppose GC games might start working at some point in the future, but it's probably not something we have to worry about.

  2. I mostly agree with what you said (although detecting if disc 1 is part of a multi-disc game is impossible, because they look identical to disc 1 of a single-disc game). But what I was thinking of was how to implement it. The way things are right now, DVDInterface doesn't know anything about what the path to the current or the next disc image is, except in the very moment the user presses "Change Disc".

Actions #3

Updated by magumagu9 almost 10 years ago

There are no two-disk Wii games.

There isn't any way to tell whether we're looking at disk one of a two-disc game, short of hardcoding a list of known two-disc games.

If you want something small to start with, you could OSD::AddMessage() to display a hint to use the Change Disc menu item, and we could see how that works without any invasive changes.

Actions #5

Updated by rachelbryk almost 10 years ago

Just search for a game with the same ID but disk number 1 higher than the current one. Single disc games will obviously find nothing, so just do nothing in that case.

Actions #6

Updated by JosJuice almost 6 years ago

  • Status changed from New to Fixed
  • Fixed in set to 5.0-9343
Actions

Also available in: Atom PDF