Emulator

Sorry... Didn't realize I couldn't edit the title after I submitted the issue. :-(

Issue title should be "D-Pad Mapping Incorrect with Nyko AirFlo EX Controller on Mac OS X"

Please show a screenshot of the GCpad window.

It could be an issue with SDL if we use that on Mac OSX. Either way, even if it maps incorrectly, does it control properly?
No, unfortunately it does not seem to control properly. It seems that what is showing on the red squares in the control config is actually happening in game as well ("up" on controller triggers "up right" on Dolphin, "down" triggers "down left", "right" triggers "up down right", and "left" triggers "left").

Please show a screenshot of the GCpad window.
I have included a video demonstrating the issue, which I think is showing the GCpad window the entire time. Is there something else that I could provide that would be more helpful?

Video of issue: https://www.youtube.com/watch?v=QKBy-jwjsms

Does it work with you right click the button of each control in the GCpad window, select the Nyko in the window that appears, press clear, scroll through the list of controls and click on the one to map, then click Select and OK? Repeat this for all of the other controls.

Does it work with you right click the button of each control in the GCpad window, select the Nyko in the window that appears, press clear, scroll through the list of controls and click on the one to map, then click Select and OK? Repeat this for all of the other controls.

If I do that, it looks correct in the UI, but then "up" is triggered without pressing anything, almost as if it is miscalibrated.

Here's a video demonstrating what happens after I do what you suggested: https://www.youtube.com/watch?v=WTp9WyzZ0rg&feature=youtu.be

Does this work with any other emulators? I'm beginning to doubt this is a problem that would be localized to Dolphin.

Does this work with any other emulators? I'm beginning to doubt this is a problem that would be localized to Dolphin.

Yes it does. As stated in the original issue description, mapping the d-pad for this controller works correctly in OpenEmu 1.0.4 on the exact same system. Here is a video showing the controller correctly mapping in OpenEmu: https://www.youtube.com/watch?v=dMBDJ4p95bk&feature=youtu.be (I also tested games to make sure it actually worked; they were just not included in the video.)

Just tried build 6638 of Dolphin and the issue persists, so it does seem to be an issue somewhere in how the d-pad is mapped. Is there a way to provide a custom mapping config file or something?

What does OpenEmu use for input? Could you try other programs that are either multi-platform, or use SDL for input?

What does OpenEmu use for input? Could you try other programs that are either multi-platform, or use SDL for input?

I think each emulator within OpenEmu handles input differently.

I just tried Mupen64Plus via M64Py (a cross-platform emulator that uses SDL for input) and it worked: http://youtu.be/gxIOY6sYoOM

Mupen64Plus GitHub: https://github.com/mupen64plus

Here is where Mupen64Plus appears to be mapping the controls via SDL: https://github.com/mupen64plus/mupen64plus-input-sdl/blob/master/src/config.c

I finally got around to building Dolphin on OS X and I fixed this issue in my case.

I edited ControlState Joystick::Hat::GetState() in https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/InputCommon/ControllerInterface/OSX/OSXJoystick.mm#L227 to basically ignore case 0 (since the default state of my controller's hat is 0) and also bind 1/up, 3/right, 5/down, 7/left. After doing that, everything worked perfectly for my Nyko controller.

This seems like a hack, so I'm wondering if there is a better way to handle this so that it would not break other controllers on OS X. Unfortunately the Nyko is the only one I have available to test with.

ControlState Joystick::Hat::GetState() const
{
	IOHIDValueRef value;
	int position;

	if (IOHIDDeviceGetValue(m_device, m_element, &value) == kIOReturnSuccess)
	{
		position = IOHIDValueGetIntegerValue(value);

		switch (position)
		{
		case 0:
			if (m_direction == up)
				//return 1;
			break;
		case 1:
			if (m_direction == up)// || m_direction == right)
				return 1;
			break;
		case 2:
			if (m_direction == right)
				return 1;
			break;
		case 3:
			if (m_direction == right)// || m_direction == down)
				return 1;
			break;
		case 4:
			if (m_direction == down)
				return 1;
			break;
		case 5:
			if (m_direction == down)// || m_direction == left)
				return 1;
			break;
		case 6:
			if (m_direction == left)
				return 1;
			break;
		case 7:
			if (m_direction == left)// || m_direction == up)
				return 1;
			break;
		};
	}

	return 0;
}