Project

General

Profile

Emulator Issues #8442

Banner mirroring for right-to-left writing systems

Added by Anonymous about 4 years ago. Updated 5 months ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
UI
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Interface issue. Tested on 4.0-5973.

While using Dolphin on a right-to-left OS (Windows 7 x64, default language - Hebrew) both the game banner and the system banner are flipped right-to-left as well as the entire interface.

What did you expect to happen instead?
The interface flipping is intended, I guess - but the banners shouldn't be flipped.

http://i.imgur.com/2RGvpXl.jpg

(On another note, half of the interface isn't translated properly or at all. I'm willing to help retranslating it, but that's another issue altogether)

History

#1 Updated by JosJuice about 4 years ago

  • Status changed from New to Accepted
  • Category set to ui

The "Controllers" icon and the flags in the game list shouldn't be flipped either, right?

#2 Updated by MayImilae about 4 years ago

  • Milestone set to Current

#3 Updated by Anonymous about 4 years ago

@JosJuice Yeah, it seems like EVERY UI graphics is flipped when using a right-to-left language. Silly me for not noticing it.

#4 Updated by JMC4789 almost 4 years ago

The one idea I had that we could do is to make flipped versions of every UI graphic, but then the game banners would still be flipped wrong. I'm really bad at figuring out WXWidgets stuff :(

#5 Updated by PEmu almost 4 years ago

Shouldn't something like this be done at the OS level? How do other applications handle right-to-left interfaces? Having to include 2x the number of UI assets sounds like a bit much.

#6 Updated by JosJuice almost 4 years ago

We can have a bit of code that mirrors the banners when they're loaded, if necessary. I don't know if the same is possible with the other images. This sounds too hacky to be a proper solution, though...

#7 Updated by Anonymous almost 4 years ago

I don't think the system language is directly related to it. My system language is set to English (everything is left-to-right), and I've tested 3 changes:

  1. Setting Hebrew as UI language - Some UI elements are translated, graphics are flipped.

  2. Setting "system language" as the UI language - UI is in English, graphics are flipped.

  3. Using English as the UI language - UI is in English, graphics AREN'T flipped.

So it seems that the OS is sending Dolphin extra information regarding the alignment of UI elements, and the same data is included in the right-to-left language packs. It should be possible to separate the two, as Dolphin did in the second case.

Small note: deleted previous comment for some misleading information.

#8 Updated by Fog almost 4 years ago

This is not something that we can easily fix, it's an issue with wxWidgets itself with it's crappy RTL support.

This should probably be moved to Future milestone once the Qt UI is feature-complete.

#9 Updated by JosJuice almost 4 years ago

  • Milestone deleted (Current)

#10 Updated by Billiard26 5 months ago

  • Status changed from Accepted to Fixed

This shouldn't be an issue in Qt.

#11 Updated by JosJuice 5 months ago

Confirmed fixed in Qt. We don't actually enable RTL layout for RTL languages out of the box, though. I patched the source code to test RTL layout.

Also available in: Atom PDF