Project

General

Profile

Actions

Emulator Issues #8494

closed

Unhandled exception when trying to open properties window in japanese verion of arc rise fantasia

Added by deffyk over 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?
ARC RISE FANTASIA

Game ID?
RPJJ99

What's the problem? Describe what went wrong in few words.
Crash when trying to access properties window

What did you expect to happen instead?
Properties window

What steps will reproduce the problem?

  1. right click on the game
  2. properties

Dolphin 3.5 and 3.5-367 are old versions of Dolphin that have
known issues and bugs, so don't report issues about them and test the
latest Dolphin version first.
Which versions of Dolphin did you test on?
4.0-4901-x64,4.0-6052-x64

Does using an older version of Dolphin solve your issue? If yes, which
versions of Dolphin used to work?
4.0-4898-x64

What are your PC specifications? (including, but not limited to: Operating
System, CPU and GPU)
Windows 7, Geforce 740, Athlon 2 x4 630

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)
https://imgur.com/WsHLcS

I don't have any other japanese games to confirm if this is the only game having these problems.
There's also a freeze after a cutscene in the second town, which isn't present in older version. It is possible it's a completely different issue.

Actions #2

Updated by JMC4789 over 9 years ago

That points to a JosJuice commit that fixed Wiigames not reading correctly. Must be some kind of file system shenanigans.

Actions #3

Updated by metafalica over 9 years ago

By the way, for my ticket here: https://code.google.com/p/dolphin-emu/issues/detail?id=8471 using 4898 doesn't help at all.

Actions #4

Updated by JosJuice over 9 years ago

This is a wild shot, but does PR 2286 affect anything? http://dl.dolphin-emu.org/prs/pr-2286-dolphin-latest-x64.7z

Actions #5

Updated by deffyk over 9 years ago

Nope. Exactly the same.

Actions #6

Updated by JosJuice over 9 years ago

There's not much I can do without more error details (which I don't think is possible to get using a regular Dolphin build?) or access to the game.

Actions #7

Updated by deffyk over 9 years ago

Is there anything specific i can look for? I've installed vs2012 as in this guide (my knowledge of this stuff is very limited) https://github.com/dolphin-emu/dolphin/wiki/Building-for-Windows and exception is being thrown right at this line

CISOProperties* ISOProperties = new CISOProperties(iso->GetFileName(), this);

iso->GetFileName() gets what its supposed to and second argument too looks pretty normal.

Only unusual thing i've noticed is
const GameListItem* iso = GetSelectedISO(); contains アークライズファンタジア" as a description

Actions #8

Updated by JosJuice over 9 years ago

Try to put a breakpoint on the constructor in ISOProperties.cpp (it's at line 112 in the newest version), step through it and check if the error occurs during any of its lines.

Actions #9

Updated by deffyk over 9 years ago

In ISOProperties.cpp line 258

CreateDirectoryTree(PartitionRoot, partition.Files, 1, partition.Files.at(0)->m_FileSize);

std::out_of_range

Microsoft C++ exception: std::out_of_range at memory location 0x000000000012B3F0.

https://imgur.com/uScYnmv

Actions #10

Updated by JosJuice over 9 years ago

That is indeed some sort of file system shenanigans. I have no idea how 4.0-4901 could cause this, but I'll fix ISOProperties to handle the case where there are no files.

Actions #11

Updated by JosJuice over 9 years ago

PR 2325 contains a fix for ISOProperties. I don't think it fixes the underlying issue, so the Filesystem tab is probably not going to work for this game (did it work in earlier Dolphin versions?) but it should fix the exception. https://github.com/dolphin-emu/dolphin/pull/2325

Windows build: http://dl.dolphin-emu.org/prs/pr-2325-dolphin-latest-x64.7z

Actions #12

Updated by deffyk over 9 years ago

Yep, works. Big thanks!
Interestingly filesystem tab works, but result is little different from what it was before. https://i.imgur.com/EbtJ2Q8.png?1

Actions #13

Updated by JosJuice over 9 years ago

  • Status changed from New to Fix pending

The disc has probably been scrubbed in some weird way that removes the update partition without removing it from the partition table. I found a little change in filesystem behavior in 4.0-4901 -- the magic word is being read from the disc header instead of the partition header -- and it makes sense with all of this. I will probably end up restoring the old behavior in another PR I've been working on, but there isn't really anything wrong with the current behavior, so I'm going to say that PR 2325 is a proper fix for this issue.

Actions #14

Updated by metafalica over 9 years ago

Just for info, since it visually similar issues with opening iso properties:
PR 2325 didn't fixed anything for me here https://code.google.com/p/dolphin-emu/issues/detail?id=8471

I will also try to look for the code line in vs2012 when I will have enough time to install it.

Actions #15

Updated by JosJuice over 9 years ago

  • Status changed from Fix pending to Fixed
Actions

Also available in: Atom PDF