Project

General

Profile

Actions

Emulator Issues #8573

closed

GPLv2+ Relicensing: LinesPrower could not be reached

Added by phire over 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Other
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

All attempts at contact have failed.

LinesPrower contributed 22 commits

https://github.com/dolphin-emu/dolphin/commits?author=linesprower

The affected components are mostly Interpreter, JIT64, and JITIL but the commits may be affected.

To resolve this issue, each commits in question need to be either proven to no-longer be in dolphin, or un-copyrightable or the code needs to be re-written.

Actions #1

Updated by flacs over 9 years ago

Just making sure this doesn't read like we're trying to guilt-trip someone :3

Actions #2

Updated by phire over 9 years ago

One major feature that appears to still be in our code (mostly untouched) is idle skipping in both jit64 and jitil.

Idle skipping really needs to be rewritten anyway, LinesPrower's implementation is explicitly commented as a hack, and it's hacky.

Actions #3

Updated by flacs over 9 years ago

  • Status changed from New to Won't fix
Actions #4

Updated by LinesPrower over 9 years ago

I just sent my consent. Sorry for the delay.
By the way, I don't remember writing idle skipping, maybe I just tinkered with it.
IIRC, my most significant contribution was improved JIT cache, I don't know if it's still in use.
Good luck with the project, and sorry again if I caused much trouble by not responding in time.

Actions #5

Updated by phire over 9 years ago

  • Status changed from Won't fix to Fixed
Actions #6

Updated by phire over 9 years ago

Thanks for your reply.

Actions #7

Updated by JMC4789 over 9 years ago

We greatly appreciate this. Thank you again. You definitely had commits that remained in Dolphin, and we didn't want to rewrite any of our contributors from the project.

Actions

Also available in: Atom PDF