Project

General

Profile

Actions

Emulator Issues #8612

closed

compile failure for git version on linux: enet_socket_get_address: not declared

Added by samuel.bauer.fr over 7 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Running on a gentoo box, with enet-1.3.7 installed
Compiling fails:
/var/tmp/portage/games-emulation/dolphin-9999/work/dolphin-9999/Source/Core/Common/ENetUtil.cpp: In function 'void ENetUtil::WakeupThread(ENetHost*)':
/var/tmp/portage/games-emulation/dolphin-9999/work/dolphin-9999/Source/Core/Common/ENetUtil.cpp:21:49: error: 'enet_socket_get_address' was not declared in this scope

Culprit is the logic in CMakeList.txt
if (ENET_FOUND)
message("Using shared enet")
else()
message("Using static enet from Externals")
include_directories(Externals/enet/include)
add_subdirectory(Externals/enet)
endif()

But latest version of enet doesn't declare "enet_socket_get_address"
Should replace ENET_FOUND with something like: "ENET_FOUND AND ENET_VERSION < 1.3.0"

see: https://bugs.gentoo.org/show_bug.cgi?id=550850

Actions #2

Updated by samuel.bauer.fr over 7 years ago

I checked a bit further, enet_socket_get_address, disappeared form the enet API for some version, and now is reintroduced.
from what I see:
enet-1.3.6 doesn't declare
enet-1.3.7 doesn't declare
but:
enet-1.3.12 declare it again.

Actions #3

Updated by comexk over 7 years ago

  • Status changed from New to Accepted

Yuck. At this point a PR to customize enet - in a protocol compatible way, but for somewhat significant efficiency improvements - is literally in the queue (not up to date though), and I am not super hopeful about upstreaming going quickly once it's all finished (although I could be wrong), so I'm not a big fan of using shared enet in the first place...

Anyway, I'll fix the build script.

Actions #4

Updated by JosJuice over 7 years ago

  • Status changed from Accepted to Fixed
Actions

Also available in: Atom PDF