Project

General

Profile

Actions

Emulator Issues #8681

closed

Netplay traversal disconnect pauses emulation and possible lag on unstable connection to traversal server

Added by CLShortFuse over 9 years ago. Updated about 8 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

It seems as though, after creating a netplay connection, the connection with the traversal server is still up. I figure this is probably to allow other people to connect when emulation is in a stopped state.

To explicit stately my issue, I've been connecting with the Smashladder traversal server. If the connection with the traversal server goes down, Dolphin will pause emulation with an error pop up. I can't remember exactly what it says, but it might have said "Connection with the traversal server has been lost." This message is probably better in a passive state in the netplay window.

I also have a second question, is the connection with the traversal server on a separate thread? I've been having a suspicion that it's synchronized with the emulation, and if there's a slow down with the traversal server, there's slow down in-game. I've been pinging smashladder's traversal server and have noticed a good amount of packet loss (~8%) and I'm hoping that it in no way affects my connection with whomever I'm playing.

Edit: Unless I'm reading wrong, it seems to continue to ping the traversal server on the same thread as the netplayclient.

https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/NetPlayClient.cpp#L526
https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Common/TraversalClient.cpp#L250

It seems both would be related.

Actions #2

Updated by comexk over 9 years ago

It is run on the same thread, but it's a tiny asynchronous routine that certainly won't cause any lag.

The dumb behavior on disconnect is yet another casualty of Ziek's incomplete port of my old branch...

Actions #3

Updated by JMC4789 over 9 years ago

  • Status changed from New to Accepted

Had this occur earlier today on Dolphin's traversal server.

Actions #4

Updated by Aestek over 8 years ago

Actions #5

Updated by JosJuice about 8 years ago

  • Status changed from Accepted to Fixed

If you say so, I'll close the issue. If anyone still has this problem, please write a comment.

Actions

Also available in: Atom PDF