Emulator

I don't run into this issue myself, was testing it the other day.

I tried it again, and apparently it only happens when pausing the game using the Frame Advance key, a massive habit of mine.

1. Start recording input
2. Press Frame Advance to pause emulation
3. After a few frame advances, emulation should unpause by itself.

Seems to happen with all revisions tested. If anything, Frame Advance shouldn't work unless emulation is initially paused.

https://www.youtube.com/watch?v=bV0JigjU6Mg&feature=youtu.be

This is a regression from 4.0-5402, when the hotkey functionality changed Wrong.

Please test this again with the latest development version.

still an issue as of 4.0-7099

to further comment on this, pressing play and pause repeatedly will also trigger the issue.

Fog, do you want to own this?

This seems to be more an issue with how the GUI interacts with the CPU core than just a single frame advance issue. Possibly a race condition?

Nevertheless, I think the title is misleading because frame advance is probably not the only place this issue occurs, but it's the most obvious place to find these issues.

@delroth: This issue is probably better suited for someone with much more intricate knowledge of the GUI and CPU emulation.

This isn't as much of a blocker in comparison to the rest of the blockers, I'd be okay with having it removed from Current milestone.

It's a regression which makes TASing really annoying.

I'm trying to understand what happens here. To me it looks way to obvious:
"Press Frame Advance to pause emulation"
and then press the same button to continue? So Dolphin executes the hotkey 2 times in a row, even if it's just pressed once? That doesn't sound like a race condition with pause/unpause, but an issue with hotkey handling.