Project

General

Profile

Actions

Emulator Issues #8733

closed

Cab't open SSBB's properties when it's in WBFS format.

Added by rukariosake almost 9 years ago. Updated over 8 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

(Title says it all.)

Game Name?
Super Smash Bros. Brawl

Game ID?
RSBE01

What's the problem? Describe what went wrong in few words.
When I've tried to open properties for Super Smash Bros. Brawl in WBFS format, unhandled exception error will pop up.

What did you expect to happen instead?
Properties window opens

What steps will reproduce the problem?
[Don't assume we have ever played the game and know any level names. Be as
specific as possible.]

  1. Rip Super Smash Bros. Brawl in WBFS format (I've used USB Loader GX)
  2. Then in Dolphin's gamelist, open properties for Smash Bros. Brawl (right-click -> Properties)

Which versions of Dolphin did you test on?
I wasn't able to open Brawl's properties for long time, thinking it's a bad dump and I was too lazy to actually redump it, but today I do it! The problem persists. I've tried many earlier Dolphin builds, and i was able to narrow down to specific build the problem introduced in.

It's 4.0-4441

I should've report about it sooner. My apologies!

Actions #1

Updated by JosJuice almost 9 years ago

Huh, magumagu's old partition fixes... If it breaks SSBB specifically, it's probably because ISOProperties now also scans for groups, which only SSBB has more than one of. I don't know why that causes a problem with WBFS, but maybe PR 2353 affects it. Please try it out: http://dl.dolphin-emu.org/prs/pr-2353-dolphin-latest-x64.7z

Actions #2

Updated by rukariosake almost 9 years ago

Tried that link, still getting a unhandled exception error.

Actions #3

Updated by rukariosake almost 9 years ago

I even tried on on two different PC's

But they're mine and have similar configurations. Are you able to open properties for SSBB when it's in WBFS on your setup? Like right now?

I suspected it was because of .WBF1 but that's not the case. I can open Xenoblade Chronicles and Metroid Trilogy which have .WBF1.

Actions #4

Updated by JosJuice almost 9 years ago

I've never used WBFS before. I'll convert my SSBB ISO to it and test when I get time, maybe this weekend.

Actions #5

Updated by rukariosake almost 9 years ago

Okay, great

Actions #6

Updated by rukariosake almost 9 years ago

Possible culprit is that ISOProperties (something you mentioned earlier) ignored .WBF1 (game is divided into WBFS and WBF1 when it's more than 4GB). It might only focus on one .WBFS and that's it. I can imagine the disc image will appear to be corrupted when .WBF1 is ignored or not found.

Actions #7

Updated by rukariosake almost 9 years ago

When I merged WBFS and WBF1 into one whole WBFS (just by "copy /b RSBE01.wbfs + RSBE01.wbf1 full.wbfs" in command prompt) Dolphin can read it, and properties window still can't open.

So WBF1 is not the culprit apparently...

I deleted full.wbfs as it was just for testing.

I converted WBFS back to ISO (thanks to wbfs_file.exe by kwiirk that I can simply drag'n'drop to convert WBFS to ISO and vice versa), Dolphin can read it, and now properties window can also opens properly.

Then the interesting part is, when I convert it back to WBFS (WBFS and WBF1 like usual), properties window opens OK.

Actions #8

Updated by JosJuice almost 9 years ago

Which program did you originally create the WBFS disc image in?

Actions #9

Updated by rukariosake almost 9 years ago

I used USB Loader GX on Wii

It will rip Brawl disc as WBFS and WBF1

Actions #10

Updated by rukariosake almost 9 years ago

I think I was mistaken about properties window able to open Brawl that has been re-converted back to WBFS. Maybe it's actually ISO. I removed path in Dolphin settings so I lost track of it.

Actions #11

Updated by rukariosake almost 9 years ago

I mean I perma-deleted re-WBFS and re-created it to make sure, the error came up once again, hence I lost track of it.

Actions #12

Updated by JosJuice almost 9 years ago

So the error always appears when you are using WBFS?

Actions #13

Updated by rukariosake almost 9 years ago

For Brawl yes

Every other games no

Actions #14

Updated by JosJuice almost 9 years ago

I couldn't reproduce this when making a WBFS file with Wii Backup Manager, but I could reproduce it using wbfs_file.exe. For some reason, the file system code gets an abnormally large size of the FST in the first partition in the second group, and then the exception occurs when it tries to allocate that much memory. I still need to investigate why it doesn't get the right size, but PR 2610 should work as a workaround: http://dl.dolphin-emu.org/prs/pr-2610-dolphin-latest-x64.7z

Actions #15

Updated by rukariosake almost 9 years ago

AHH I remember now! I did used Wii Backup Manager in one of my test and properties window brought up.

I am receiving warning message saying it's "Read beyond end of disc".

Actions #16

Updated by JosJuice almost 9 years ago

  • Status changed from New to Questionable

The entry in WbfsBlob's m_wlba_table that points to that partition's FST is 0, and I don't know why. Maybe the file simply is broken. When using a file where the properties window doesn't work, do the Masterpieces work in either Dolphin or a Wii backup loader? (Except for OoT in Dolphin - that one never works regardless of what you do)

Actions #17

Updated by rukariosake almost 9 years ago

The masterpieces doesn't work on both Dolphin and USB Loader GX and I have a feeling you will mark it as WontFix. It's disappointing realizing that USB Loader GX and wbfs_file.exe been making bad files.

Actions #18

Updated by JosJuice almost 9 years ago

There isn't anything we can do to make all the partitions work properly, but making it possible to open the properties window despite the partition errors is reasonable. Did PR 2610 let you do that?

Actions #19

Updated by rukariosake almost 9 years ago

I used PR 2610 when I said I am receiving "Read beyond end of disc".

Sorry, I should have stated that before.

Actions #20

Updated by rukariosake almost 9 years ago

BTW the "game" partition is in partition 0 in bad WBFS file while in the ISO file, it is on partition 1, so maybe that explains why PR 2610 tries to read partition 1 then throw a warning because partition 1 is blank. I haven't tried good WBFS and WBFS through wbfs_file.exe.

Actions #21

Updated by rukariosake almost 9 years ago

Apparently the "game" in partition 1 in WBFS still receive a warning. Nevermind about what I said earlier.

Actions #22

Updated by JosJuice almost 9 years ago

  • Status changed from Questionable to Fix pending

What I was wondering was if the properties window shows up after the warning. It turns out that it doesn't, because a bug in Dolphin's WBFS code causes an infinite loop when that warning appears. I have created PR 2712, which solves this problem. With PR 2610 and PR 2712 combined, the properties window will work with the broken WBFS file (although there are four warning messages or so, and all Masterpiece partitions are inaccessible). There are unfortunately no combined builds available, so you can't test this on your own.

https://github.com/dolphin-emu/dolphin/pull/2610
https://github.com/dolphin-emu/dolphin/pull/2712

Actions #23

Updated by JosJuice almost 9 years ago

  • Milestone set to Current
Actions #24

Updated by rukariosake almost 9 years ago

Yes, I also forgot to say that warning message is infinite when I tried PR 2610.

This is going to be a great news for users who have been ripping/converting discs/ISOs to broken WBFS files the whole times. Thank you very much.

Actions #25

Updated by JosJuice almost 9 years ago

PR 2712 has been merged, and I've rebased PR 2610 with all the recent changes on the stable branch, so this build of PR 2610 should now be able to open the properties window: http://dl.dolphin-emu.org/prs/pr-2610-dolphin-latest-x64.7z

Actions #26

Updated by rukariosake almost 9 years ago

Confirmed working after several "Read beyond end of disc" warning messages. I (and others) will be fine with that. You did great!

Actions #27

Updated by JosJuice over 8 years ago

PR 2610 has been replaced with PR 3206. The only difference is that it now is based on master instead of stable.

Actions #28

Updated by JosJuice over 8 years ago

  • Status changed from Fix pending to Fixed

Fixed in 4.0-8183.

Actions

Also available in: Atom PDF