Project

General

Profile

Emulator Issues #8734

Temporary setting overrides from ie. GameINIs can be written to the global configuration on improper shutdown.

Added by Pikachu025 almost 5 years ago. Updated over 2 years ago.

Status:
Fix pending
Priority:
Normal
Assignee:
-
% Done:

80%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

It's possible for settings that should be temporary for a single session only to be written to the global Dolphin.ini, which then affects other games launched later if not manually changed again.

To reproduce:
* Find a game that has GameINI overrides that don't match your current configuration.
* Launch the game.
* Open the Config window.
* Press OK.
* Terminate Dolphin in a way where it has no chance to clean up after itself, for example with the Task Manager, or trigger a Dolphin crash somehow.
* Relaunch Dolphin.

The temporary overrides from the game are now still set as the global configuration.

This happens because Dolphin writes the Dolphin.ini when you press OK in the Config window, regardless of if the current settings are global or session-specific. On normal shutdown this would correct itself later when the config cache is loaded back into the global configuration, but if you don't give Dolphin the chance to do that, the modified configuration remains.

This is a minor annoyance in some cases, but a severe usability issue for settings that don't have any actual way to change them in the GUI. For example, SyncGPU can be forced on for all games with no good way to disable it without manually editing Dolphin.ini.

History

#1 Updated by Pikachu025 almost 5 years ago

Hotfix: https://github.com/dolphin-emu/dolphin/pull/2687
Should be properly fixed at some point though.

#2 Updated by JosJuice over 4 years ago

  • Status changed from New to Fixed

#3 Updated by JosJuice over 4 years ago

  • Status changed from Fixed to New

#4 Updated by leoetlino over 2 years ago

  • Status changed from New to Fix pending
  • % Done changed from 0 to 80

Also available in: Atom PDF