Project

General

Profile

Emulator Issues #8860

Star Wars - Rogue Squadron III Water Shader

Added by kolano almost 5 years ago. Updated over 4 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?
Star Wars - Rogue Squadron III - Rebel Strike

Game ID?
GLRE64

What's the problem? Describe what went wrong in few words.
The shader used to draw water fails to compile and leaves gaps in the terrain where it should be used. On some machines it seem to compile, but rendered static instead of the expected results.

What did you expect to happen instead?
Shader to compile and render as on the GameCube.

What steps will reproduce the problem?
1. Select game slot
2. Start "Revenge of the Empire"
3. Enter X-wing
4. Wait for text scroll and Empire fleet to arive
5. Shortly after the pan acroll the planet starts a shader error occurs (see screenshot below).

Dolphin 3.5 and 3.5-367 are old versions of Dolphin that have
known issues and bugs, so don't report issues about them and test the
latest Dolphin version first.
Which versions of Dolphin did you test on?
4.0-7207

Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?
In theory 4.0-6818 renders correctly, but I haven't tested myself.

What are your PC specifications? (including, but not limited to: Operating
System, CPU and GPU)
Windows 7, Intel i7-960, NVIDIA 580

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)
https://wiki.dolphin-emu.org/index.php?title=File:Star_Wars_Rogue_Squadron_III-Water_Shader_Compile.png
https://wiki.dolphin-emu.org/index.php?title=File:Star_Wars_Rogue_Squadron_III-Water_4.0-7143.jpg
https://wiki.dolphin-emu.org/index.php?title=File:Star_Wars_Rogue_Squadron_III-Water_4.0-6818.jpg

History

#1 Updated by JMC4789 almost 5 years ago

  • Status changed from New to Questionable

Water works fine here, doesn't popup with anything, and it animates as it did before.

GTX 760, OpenGL

#2 Updated by kolano almost 5 years ago

Yeah, not sure. I was seeing the vertex shader compile error consistently last night on 4.0-7207. In that case portions of the terrain that should have water rendered on them were just holes to the background.

That's was different than the report on the wiki against 4.0-7143, which seemed to render the water, but as static rather than waves.

I'll try to do some more testing against different releases later today.

#3 Updated by kolano almost 5 years ago

I can confirm that...

4.0-6818: Renders water appropriately
4.0-7207: "PixelShader generator - buffer too small, canary has been eaten!" water renders as holes.
4.0-7325: "PixelShader generator - buffer too small, canary has been eaten!" water renders as holes.
5.0-rc-15: Renders water appropriately

So it seems some recent update had broken things, Needs some further testing to work out what.

#4 Updated by kolano almost 5 years ago

4.0-7005: Renders water appropriately
4.0-7072: Renders water appropriately
4.0-7976: Renders water appropriately
4.0-7078: "PixelShader generator - buffer too small, canary has been eaten!" water renders as holes.
4.0-7099: "PixelShader generator - buffer too small, canary has been eaten!" water renders as holes.
4.0-7143: "PixelShader generator - buffer too small, canary has been eaten!" water renders as holes.

So it seems to have been caused by "Work around PowerVR's shader compiler. #2759"

#5 Updated by JosJuice almost 5 years ago

  • Status changed from Questionable to Fix pending
  • Milestone set to Current

Fixed in 4.0-7396, but not yet in stable. https://github.com/dolphin-emu/dolphin/pull/2894

#6 Updated by JosJuice over 4 years ago

  • Status changed from Fix pending to Fixed

Also available in: Atom PDF