Emulator Issues #8959
closed
Video dumping can't handle aspect ratio changes.
0%
Description
If the aspect ratio changes while a video is recording, recording will cause a 'you have resized the window while dumping frames, nothing can be done to handle this properly, your video will likely be broken' error message.
This wasn't an issue before, as dolphin always used exactly 4:3 or 16:9 aspect ratios and never change aspect unless you changed the force aspect ratio option. But now dolphin derives it's aspect ratio from VI timings and switches between 4:9 and 16:9 on the fly for gamecube games which means the aspect ratio isn't constant through the game.
Dolphin needs to pick one resolution to dump the video (probably specified by the user, as requested in #4773) and add black bars to the video when the aspect ratio doesn't match.
A workaround does exist for now, where you use the "Stretch to Window" aspect ratio option, after adjusting the window to the correct size (potentially by using the "auto resize window" option)
Updated by Fog over 8 years ago
To expand upon the workaround, if you play the game up to the point where it stretches the window with auto resize window, then disable auto resize window, it will work as expected.
The way it currently works is it's passing the window size and creating the video file based on that window size. It should be a simple change where we create option menus for resolution width/height. Just need to pass it through each video backend's renderer instead of passing the window's width/height.
Updated by JosJuice over 8 years ago
- Has duplicate Emulator Issues #9227: Dumping Frames Produces Garbage with Melee added
Updated by JosJuice almost 8 years ago
- Status changed from Accepted to Fixed
- Fixed in set to 5.0-97