Actions
Emulator Issues #8961
closed
GCI Folder sanity checks
Status:
Fixed
Priority:
High
Assignee:
-
% Done:
0%
Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
Yes
Relates to maintainability:
No
Regression start:
Fixed in:
Description
A pretty major bug was reported in the following thread: https://forums.dolphin-emu.org/Thread-all-gci-files-corrupted
Not sure if there are easy steps to reproduce but the fix should be trivial
either: change 'wb' to 'r+b' here https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/HW/GCMemcardDirectory.cpp#L575
or add a call to m_saves[i].LoadSaveBlocks before opening the file for writing
Updated by lpfaint99 over 9 years ago
even a check like
if (m_saves[i].m_save_data.size() > 0)
before writing would be sufficient
Updated by JMC4789 over 9 years ago
- Status changed from New to Accepted
- Priority changed from Normal to High
- Easy changed from No to Yes
Agreed.
Updated by JosJuice about 9 years ago
- Status changed from Accepted to Fix pending
- Milestone set to Current
Updated by JosJuice about 9 years ago
- Status changed from Fix pending to Fixed
Actions