Project

General

Profile

Actions

Emulator Issues #9012

closed

Compile-Fail: changed miniupnp function signature

Added by thePalindrome about 9 years ago. Updated about 5 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name/ID/Hash?
N/A

miniupnp is detected by cmake on the system, this version uses an old signature of 'UPNPDev* upnpDiscover()'

Because cmake detects miniupnp, it does not use the static version, which may or may not work (needs further testing)

Reproduce using an up to date ~amd64 Gentoo, use the attached ebuild.

This affects 5.0_rc, from github (last commit, July 31)

I'm running Gentoo Linux, Intel i5, 4GB ram, ~amd64

See build log and ebuild (attached)


Files

dolphin-5.0_rc.ebuild (4.14 KB) dolphin-5.0_rc.ebuild Custom WIP ebuild thePalindrome, 10/05/2015 11:20 PM
build.log (695 KB) build.log Failed build log (redirect from emerge) thePalindrome, 10/05/2015 11:20 PM
dolphin-9999.ebuild (4.45 KB) dolphin-9999.ebuild Updated version of the ebuild from the portage tree Shadows_Friend, 10/07/2015 05:37 AM
Actions #1

Updated by Shadows_Friend about 9 years ago

This commit should fix that particular error: https://github.com/dolphin-emu/dolphin/commit/8c5744bca705a0895bd51c966a30171ee2bab43a. If this isn't going to be backported to 5.0, you could fix it for yourself by either using the above commit as an user patch, switch to the dolphin-9999.ebuild (I'll attach an updated version of the one in the tree) or add

sed -i -e '/include(FindMiniupnpc/d' CMakeLists.txt || die
mv Externals/miniupnpc . || die

before the rm -r Externals/* line in src_prepare() and

mv miniupnpc Externals || die

after it in your ebuild to disable the discovery of the installed miniupnpc version and use the one from Externals.

Actions

Also available in: Atom PDF