Project

General

Profile

Emulator Issues #9024

Add an option to override correct aspect ratio/enable square pixels

Added by BFG1992 almost 5 years ago. Updated almost 5 years ago.

Status:
Questionable
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Feature request
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?

Any

Game ID? (right click the game in the game list, properties, info tab)

Any

MD5 Hash? (right click the game in the game list, properties, info tab, MD5 Hash: Compute)

N/A

What's the problem? Describe what went wrong.

As the title says. The main reason to do this is that some games were not correctly configured/not meant to be played with correct AR. Example is Mario Strikers Charged, see attached screenshot. Though these stretches are pretty subtle (in comparison to what was in SSBM before the AR fix) and may not be seen with naked eye, they are still wrong game-wise, no matter how accurately they are emulated.

What steps will reproduce the problem?

Launch a game like Mario Strikers Charged or some other games with such a "right-wrong" AR.

Which versions of Dolphin did you test on? Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?

All of them after 4.0-7138 are affected.

What are your PC specifications? (CPU, GPU, Operating System, more)

Intel Core i3-3120M
NVIDIA GeForce GT645M
6 GB of RAM

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)

You guys have an open PR here: https://github.com/dolphin-emu/dolphin/pull/2791
You can merge it, right? Please? :)

Screenshot.png (982 KB) Screenshot.png Mario Strikers charged incorrect AR BFG1992, 10/09/2015 12:14 AM
4993

Related issues

Has duplicate Emulator - Emulator Issues #11609: Aspect ratio switching problem. Duplicate

History

#1 Updated by JosJuice almost 5 years ago

  • Status changed from New to Questionable
  • Issue type changed from Bug to Feature request

#2 Updated by JMC4789 almost 5 years ago

You want this: https://github.com/dolphin-emu/dolphin/pull/2796

I see no reason why not to merge it, but other people disagree with me. It fixes your issue as well as acts a full enhancement, always displaying the aspect ratio the game wants, rather than "correct"

#3 Updated by BFG1992 almost 5 years ago

Wow, that looks wonderful. I wonder how exactly that heuristics part is working though.

I've read through comments, and I kinda understand phire's point, but I'm still thinking that this option should be implemented, because that would eliminate a lot of hassle of manually switching AR modes while changing games. Just not make this on by default, I guess. In any case, most users won't notice this - as very few ones noticed incorrect AR in many games in old pre-4.0-7138 builds.

#4 Updated by phire almost 5 years ago

The game, is being emulated correctly.

If we add this option people are just going to have holy wars over what is the more correct way to play the game. The way the developer (potentially) intended when they wrote the code, or the result they saw on the screen when they tested that code (which is also what QA approved)

It's not like Nindendo didn't give the developers extensive documentation describing the correct aspect ratio.

#5 Updated by BFG1992 almost 5 years ago

Well, holy wars is possible, so what? Anyone has their opinions on everything.

I still don't get how wrong could it be to give people choice between those AR modes, and to make a "smart" option which will be off by default and not recommended because of it's questionable nature.

#6 Updated by phire almost 5 years ago

For all we know, the developers of Super Mario Strikers drew a circle, realized they had the wrong aspect ratio, decided it actually looked quite nice as an oval and never fixed the aspect ratio problem.
I really doubt the QA team missed the mistake. The game was probably signed of for release with much larger known issues.

A bug fix is not an "Enhancement" as the console hardware was completely capable at getting this right. It's a mod at best, hack at worst and dolphin should not have an option to automatically mod/hack games.

Dolphin does need better modding support, things like disk overlays, function hooking, shader overrides and texture replacement by filename so groups of people can make and distribute mod packages for dolphin. That would be the proper place for such a bug fix.

#7 Updated by BFG1992 almost 5 years ago

dolphin should not have an option to automatically mod/hack games

Ok, so let's remove: non-native resolutions and EFB scaling, anisotropic filtering, antialiasing, post-processing effects, per-pixel lighting, widescreen hack... Hell, we can even remove hardware video backends - they are not accurate enough!

I'm exaggerating it now, of course. But you do understand (better than me) that Dolphin is already full of hacks. Nice, useful hacks which makes it more enjoyable to play games in Dolphin rather than on a real console! How different is a smart AR from a widescreen hack? The latter is actually worse - in many games it stretches interface and reveals clipping!

Dolphin isn't an experimental cycle-accurate emu (like XEBRA, Exodus or higan/bsnes are), but the only emu that can play GC/Wii games really good, and it's really popular among people who just want to play games - so why to pursue such an accuracy to THAT extent?

What do I want is to have a nice, useful and optional tool to make games look in the right AR, where circles are circles, and not ovals. And if this will be done in a smart way for the most games - I double want it! I'm sure I'm not only one who wants that.

#8 Updated by phire almost 5 years ago

Some people (mostly neobrain) would love nothing better but to remove all enhancements like EFB scaling, anisotropic filtering, antialiasing etc.

Enhancements make coding accuracy improvements hard. Because when you make an accuracy improvement, you have to make sure it breaks none of the enhancements, which might have relied on an assumption that is no longer true.
An enhancement may take a few minutes to implement now, but it can cost hours and hours of maintenance time later. So we need to be careful about what enhancements we add.

For the sake of the sanity of current and future dolphin developers, the line has to be drawn somewhere, and I'm drawing it here. Right between "enhancements that were simply not possible on the original hardware (like everything you mentioned)" and "automatic bug fixes for things which the developers could have taken an hour to read the manual and tweak their settings to get it correct."

If you want, I could definitely see your point that widescreen hack is on the wrong side of that line and remove it.

#9 Updated by BFG1992 almost 5 years ago

when you make an accuracy improvement, you have to make sure it breaks none of the enhancements
But why? If an accuracy improvement is important, why couldn't you just leave enhancements to be fixed by someone who cares about them? That's the power of open development, no?

I could definitely see your point that widescreen hack is on the wrong side of that line and remove it

That's the thing you should discuss with other developers, not me :) But if you do that, people will probably become really upset :)

#10 Updated by BFG1992 almost 5 years ago

Ah, forgot to press Enter a couple of times. Too bad there's no comments editing.

#11 Updated by JMC4789 almost 5 years ago

There is comments editing on our new issue tracker at least for me. IF you want to tell me what you want edited, I can go ahead and chagne it for you.

#12 Updated by BFG1992 almost 5 years ago

Umm... I can't find it. Can you point it out for me, please?

#13 Updated by JMC4789 almost 5 years ago

It may not be enabled for regular users (due to people deleting evidence/etc. that could be considered harassment, etc. Legendary double etc. right there.) I can edit it for you, though.

#14 Updated by BFG1992 almost 5 years ago

Ah, I understand.
I messed up with quotes in my last response to phire, so I wanted to fix it. But I guess it is understandable anyway, a fix will only make my message properly looking. Fix it, if you want :)

#15 Updated by JMC4789 almost 5 years ago

Fixed. Anyway, to add to the discussion, the user side of me is heavily in favor of smart aspect ratios someday. The dev side of me says they need to be implemented in a more harmless way to ease phire's fears. But, I definitely want the feature.

#16 Updated by BFG1992 almost 5 years ago

Thanks, but my first indent (beginned by "But why? If an accuracy..." and on) needs to be unquoted too.
Also, given the fact that you can edit messages, maybe you could delete our offtopic conversation about this comments thing (and my "forgot to press Enter message" too)? :)

As of an issue - I totally agree with you.

#17 Updated by eckso almost 5 years ago

I second this addition. It's a simple "AR Ratio" text with a float checkbox. Implementation is also very simple. I certainly want to play games the "correct way", rather than screwed up. As shown here (https://forums.dolphin-emu.org/Thread-correct-aspect-ratio-option?pid=380580#pid380580) there are MANY games that don't play fine even with "SmartAR". This is in my opinion a feature as relevant as "IR", because it affects/improve gameplay (perspective, depth...) in a major way.

#18 Updated by JosJuice 6 months ago

Also available in: Atom PDF