Project

General

Profile

Actions

Emulator Issues #9102

closed

DolphinWX: Controller config details shows Apply button untranslated

Added by JosJuice over 8 years ago. Updated almost 6 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Steps to reproduce:

  1. Use a localized version of Dolphin (i.e. not English).
  2. Press the Controllers button to go to the controller configuration.
  3. Press Configure on any controller that supports being configured (for instance an Emulated Wiimote).
  4. Right-click on any of the buttons that can be configured.
  5. The details window will appear. Look at the text on the button in the bottom-right corner (or bottom-left corner if you're using an RTL language).

The button always says "Apply" in English, but it should say the equivalent of "Apply" in the selected language. Tested in 4.0-8183.

The button appears to be created using CreateButtonSizer. What I don't understand is why https://github.com/dolphin-emu/dolphin/blob/584ea8b3205f703b09f7f030493150e9e526b604/Source/Core/DolphinWX/InputConfigDiag.cpp#L1074 gives a localized Cancel button while https://github.com/dolphin-emu/dolphin/blob/584ea8b3205f703b09f7f030493150e9e526b604/Source/Core/DolphinWX/InputConfigDiag.cpp#L631 gives a non-localized Apply button.

Actions #1

Updated by 8times9 almost 6 years ago

I believe this can be closed with the removal of Wx from the source code.

Actions #2

Updated by JMC4789 almost 6 years ago

  • Status changed from New to Fixed
Actions

Also available in: Atom PDF