Emulator Issues #9159
closedTAS recording ignores Wii settings
100%
Description
Reported on twitter - https://twitter.com/YuLoad/status/676071890553712640
@Dolphin_Emu When the TAS production
If you start from the recording of tool→recording→input it will go back to English rather than Japanese
I tried to reproduce it, but I neither read Japanese or use TAS input, so I didn't really have any luck. :/ It should be a quick test though.
Updated by JMC4789 over 8 years ago
I think it's the blank NAND feature causing this.
Updated by JMC4789 over 8 years ago
Our blank NAND defaults a lot of features, and language is one of them. I don't know how to fix this though, as netplay requires an identical NAND every boot. I guess DTMs need the ability to override some blank NAND features.
Updated by delroth over 8 years ago
Knowing very little about how we do things in the current way — I think instead of persisting the Wii language setting directly in SYSCONF we should store it as a Dolphin setting and apply it to the SYSCONF at boot time. We're already doing something similar for progressive and PAL60.
That sounds like a decently easy bug to fix given that there is already some code doing the same thing. Anyone interested, please submit a PR.
Updated by delroth over 8 years ago
Also: I'm not sure if we snapshot settings in DTMs. If we do, we should make sure this new settings is also snapshotted.
Updated by Fog about 8 years ago
delroth wrote:
Also: I'm not sure if we snapshot settings in DTMs. If we do, we should make sure this new settings is also snapshotted.
We do store configuration settings within the DTM header. I'll take a look at this to see what needs to be done.
Updated by Fog about 8 years ago
I've stored the language bit in the DTM file and it does appear to work, but #9355 is blocking tests to make sure it fully works.
Updated by Fog about 8 years ago
- Status changed from New to Accepted
- Assignee changed from Lioncash to Fog
Updated by Fog about 8 years ago
This issue ties into #9370, but is different enough to keep them as separate issues.
Updated by Fog about 8 years ago
- Subject changed from TAS recording switches to English to TAS recording ignores Wii settings
Updated by JosJuice about 8 years ago
- Has duplicate Emulator Issues #9355: Doc's Punch Out!!! Black screen when attempting to record input added
Updated by Fog about 8 years ago
- Status changed from Work started to Fix pending
Updated by Fog about 8 years ago
Should be fixed in PR 3668: https://github.com/dolphin-emu/dolphin/pull/3668