Project

General

Profile

Emulator Issues #9159

TAS recording ignores Wii settings

Added by MayImilae over 6 years ago. Updated over 6 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Fog
% Done:

100%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Reported on twitter - https://twitter.com/YuLoad/status/676071890553712640

@Dolphin_Emu When the TAS production
If you start from the recording of tool→recording→input it will go back to English rather than Japanese

I tried to reproduce it, but I neither read Japanese or use TAS input, so I didn't really have any luck. :/ It should be a quick test though.

Related issues

Has duplicate Emulator - Emulator Issues #9355: Doc's Punch Out!!! Black screen when attempting to record inputDuplicate

History

#1 Updated by delroth over 6 years ago

  • Assignee set to Lioncash

Lioncash, mind taking a look?

#2 Updated by Lioncash over 6 years ago

Sure, I'll take a look later today.

#3 Updated by JMC4789 over 6 years ago

I think it's the blank NAND feature causing this.

#4 Updated by JMC4789 over 6 years ago

Our blank NAND defaults a lot of features, and language is one of them. I don't know how to fix this though, as netplay requires an identical NAND every boot. I guess DTMs need the ability to override some blank NAND features.

#5 Updated by delroth over 6 years ago

Knowing very little about how we do things in the current way — I think instead of persisting the Wii language setting directly in SYSCONF we should store it as a Dolphin setting and apply it to the SYSCONF at boot time. We're already doing something similar for progressive and PAL60.

That sounds like a decently easy bug to fix given that there is already some code doing the same thing. Anyone interested, please submit a PR.

#6 Updated by delroth over 6 years ago

Also: I'm not sure if we snapshot settings in DTMs. If we do, we should make sure this new settings is also snapshotted.

#7 Updated by Fog over 6 years ago

delroth wrote:

Also: I'm not sure if we snapshot settings in DTMs. If we do, we should make sure this new settings is also snapshotted.

We do store configuration settings within the DTM header. I'll take a look at this to see what needs to be done.

#8 Updated by Fog over 6 years ago

I've stored the language bit in the DTM file and it does appear to work, but #9355 is blocking tests to make sure it fully works.

#9 Updated by Fog over 6 years ago

  • Status changed from New to Accepted
  • Assignee changed from Lioncash to Fog

#10 Updated by Fog over 6 years ago

  • Status changed from Accepted to Work started

#11 Updated by Fog over 6 years ago

This issue ties into #9370, but is different enough to keep them as separate issues.

#12 Updated by Fog over 6 years ago

  • Subject changed from TAS recording switches to English to TAS recording ignores Wii settings

#13 Updated by JosJuice over 6 years ago

  • Has duplicate Emulator Issues #9355: Doc's Punch Out!!! Black screen when attempting to record input added

#14 Updated by Fog over 6 years ago

  • Status changed from Work started to Fix pending

#15 Updated by Fog over 6 years ago

#16 Updated by Fog over 6 years ago

  • Regression changed from No to Yes

#17 Updated by delroth over 6 years ago

  • Status changed from Fix pending to Fixed

Also available in: Atom PDF