Emulator Issues #926
closedCleaning up source code!
0%
Description
Just made this issue so i can post any patch's that help clean up the
code/make it more easier to understand.
Updated by XTra.KrazzY over 15 years ago
- Status changed from New to Work started
- Issue type set to Task
- Priority set to Low
- Relates to maintainability set to Yes
- Operating system N/A added
Go for it!
Updated by death2droid over 15 years ago
Some clean up on x64Analyser.(Made some of the the case stuff easier to understand
what they do)
Updated by XTra.KrazzY over 15 years ago
Sorry to inform you this but please read the coding guidelines before modifying the
code. You would have learned that enums/macros are ALLCAPS and that they should
reside in the header files.
It would be very simple to "fix" your patch. It's a great job you're doing! :)
Updated by death2droid over 15 years ago
Sorry about that I'll go read the coding guide lines a bit more.
Updated by death2droid over 15 years ago
Here is a fixed one enum now resides in the header file and all the things under it
are now caps
Updated by XTra.KrazzY over 15 years ago
Much better. Patch looks great. I hope it's correct though ;)
Keep up the good work. Once you have 3 or so I'll commit them. I think you should ask
ector for SVN access though. That is, if you are willing to keep creating cleanups
and more great patches.
Updated by death2droid over 15 years ago
PixelEngine.cpp enum fix(Moved it to header file)
Oh yeah where should i contact ector?
Updated by death2droid over 15 years ago
Here is some work on action replay.
I recommended checking over it just in case i made a mistake as there were a lot of
cases.
Updated by bkchaw over 15 years ago
come EFnet #dolphin-emu , ector is there....
Updated by XTra.KrazzY over 15 years ago
Well death2droid, you're doing a better job than us :)
I really think you should join, you could really do some impressive stuff.
Updated by hrydgard over 15 years ago
These looks nice. Death2droid, since you're now a member, feel free to submit them.
Updated by XTra.KrazzY over 15 years ago
- Status changed from Work started to Fixed
Since you can now commit this, I am closing this issue.