Project

General

Profile

Emulator Issues #9268

Super Smash Bros. Brawl custom character Lloyd renders incorrectly

Added by ryanebola16 over 5 years ago. Updated 2 months ago.

Status:
New
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?

Super Smash Bros. Brawl

Game ID? (right click the game in the game list, properties, info tab)

RSBE01

MD5 Hash? (right click the game in the game list, properties, info tab, MD5 Hash: Compute)

7ced41449034beb74f277cbb6d5e0df0 (edited ISO, works fine on both Dolphin and real Wii)

What's the problem? Describe what went wrong.

The attached panic alert appears when displaying this Lloyd custom moveset. No problems seem to occur when panic alerts are disabled. There also appears to be a minor difference in Lloyd's appearance between 3D3 and the real Wii.

What steps will reproduce the problem?

Play as the Lloyd character. Setup for him can be somewhat complicated so let me know if the FifoCI log isn't enough to solve this problem.
Observe the Panic Alert spam

Which versions of Dolphin did you test on? Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?
4.0-8715
4.0-8706

What are your PC specifications? (CPU, GPU, Operating System, more)

Win 10 Pro x64
Intel Core i7-4702MQ CPU @2.20GHz
GeForce GT 750M
GeForce Game Ready Driver 361.43

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)

See attached

Error.PNG (642 KB) Error.PNG ryanebola16, 01/16/2016 09:25 AM
Lloyd.dff (4.95 MB) Lloyd.dff ryanebola16, 01/16/2016 09:25 AM
Real Wii.jpg (100 KB) Real Wii.jpg ryanebola16, 01/16/2016 09:25 AM
3D3.PNG (2 MB) 3D3.PNG ryanebola16, 01/16/2016 09:26 AM
LloydZoom.rar (1.75 MB) LloydZoom.rar Recorded in 4.0-9142, dual core enabled, 3D12 ryanebola16, 03/18/2016 08:21 PM
5185
5187
5188

History

#1 Updated by ryanebola16 over 5 years ago

I'm about to report a different VertexShaderGen.cpp error (error occurs on different line when both are tested in the same build).
Since the line number can change with new releases, I'll dub this as the Lloyd error.
In case this issue is related, the Lloyd error has moved to Line 260 in 4.0-8811

#3 Updated by ryanebola16 about 5 years ago

Would you be able to build that PR for me? I'd be great to get this merged before 5.0 since it should make Panic Handlers usable for me again!

#4 Updated by ryanebola16 about 5 years ago

4.0-9139 fixes issues 9268 and 9302. Thanks!

#5 Updated by JosJuice about 5 years ago

  • Status changed from New to Fixed

#6 Updated by JosJuice about 5 years ago

  • Subject changed from VertexShaderGen.cpp Line 257 Error to Super Smash Bros. Brawl custom character Lloyd renders incorrectly
  • Status changed from Fixed to New

The assert message is removed, but the rendering problem is still there. I'm changing the title to reflect that.

#7 Updated by ryanebola16 about 5 years ago

I almost forgot about that! I added a FifoCI log in LloydZoom.rar that shows a close-up pose similar to the images to make testing easier.

#8 Updated by ryanebola16 almost 4 years ago

I'm still trying to get to the bottom of this issue but it is possible that the shaders for these mods are malformed. I'm calling in some help on understanding more about shaders.

https://github.com/libertyernie/brawltools/issues/121

#9 Updated by ryanebola16 almost 4 years ago

As per the discussion at https://github.com/libertyernie/brawltools/issues/121, this issue is indeed caused by malformed materials and shaders for this custom mod. Although Dolphin and the real Wii display this model differently, both are encountering invalid shader data.

#10 Updated by ZephyrSurfer 2 months ago

Per-Pixel Lighting affects this. But it's still not quite right, and Software Renderer is overly bright which doesn't have such a setting.

Can someone capture the exact same frame from the fifolog look on a real wii.

#11 Updated by Miksel12 2 months ago

How did you test the software renderer? It fails on FifoCI.

#12 Updated by ZephyrSurfer 2 months ago

The Software Renderer has an assert in method TransformTexCoord at line 419 in VideoBackends/Software/TransformUnit.cpp which I ignored to see the rendered fifolog.

I am guessing FifoCI does not ignore warnings

#13 Updated by Miksel12 2 months ago

Ah, ofcourse.

Also available in: Atom PDF