Project

General

Profile

Emulator Issues #9360

Disc load speeds no longer accurate after 4.0-8919

Added by RibShark over 3 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?
Tested: Rayman 3 and Rayman Arena, may effect other games

Game ID? (right click the game in the game list, properties, info tab)
GRHE41 for Rayman 3, GRYE41 for Rayman Arena

MD5 Hash? (right click the game in the game list, properties, info tab, MD5 Hash: Compute)
40386ae7cb46600bf05e8980c0773ffc for Rayman 3
4e7b4dd0444ebfeb7ec2ab253116d437 for Rayman Arena

What's the problem? Describe what went wrong.
Any builds after and including 4.0-8919 no longer emulate disc load times accurately, at least on the two games I have tested. In both cases after build 4.0-8919 the load times decreased by around 2 seconds, equivalent to if "Speed up Disc Transfer Rate" were checked. I have verified using recordings from a Wii (albeit not my own, but from someone I trust) that the previous, longer load times were accurate.

What steps will reproduce the problem?
Time a loading screen on either Rayman 3 or Rayman Arena (other games may be affected, I do not currently have the resources to test that) on both 4.0-8919 and 4.0-8916. On build 4.0-8916, the load times should be around 2 seconds longer.

Which versions of Dolphin did you test on? Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?

4.0-8919 - FAILURE
<=4.0-8916 - SUCCESS

What are your PC specifications?
Intel 4690, Nvidia GTX 970, Windows 10 x64, Samsung 850 Evo (on which the game is stored)


Related issues

Has duplicate Emulator - Emulator Issues #9363: Spongebob's Boating Bash hangs on opening logo screenDuplicate

Has duplicate Emulator - Emulator Issues #9374: Shrek 2 crashing as of DVD Signedness fixDuplicate

Has duplicate Emulator - Emulator Issues #9375: Super smash bros melee broken audioDuplicate

History

#1 Updated by MayImilae over 3 years ago

  • Milestone set to Current
  • Regression changed from No to Yes

I'm not qualified to investigate this, but it would be bad to regress on this before 5.0!

#2 Updated by JosJuice over 3 years ago

That 4.0-8919 makes loading times faster sounds normal, but I would not have expected that it makes loading times drift away from console timing so much that they match Speed Up Disk Transfer Rate. The bug that 4.0-8919 fixed was most likely hiding timing flaws we have elsewhere in the code, so I'm not sure what can be done about this... It's not impossible that the change created a new timing flaw, though. It would be good if others can contribute with loading time measurements from other games.

#3 Updated by RibShark over 3 years ago

JosJuice wrote:

That 4.0-8919 makes loading times faster sounds normal, but I would not have expected that it makes loading times drift away from console timing so much that they match Speed Up Disk Transfer Rate.

On further testing, it seems like I made a mistake when timing it, and you are correct that while it makes load times faster, they do not drift that far. I'm sorry if I caused any confusion.

#4 Updated by JosJuice over 3 years ago

  • Status changed from New to Invalid

No, thank you for making the issue report and then correcting it when needed. It wasn't an inconvenience, and if you hadn't made this, I wouldn't have realized that the loading times became slightly faster. I am however going to mark it as invalid, because we're still in the same situation as before 4.0-8919: Dolphin's loading times are slightly too fast because we don't have a correct model for how the read head moves when seeking.

#5 Updated by JosJuice over 3 years ago

  • Status changed from Invalid to Fix pending

Actually, it seems like that change uncovered a timing bug, not just something that's a bit inaccurate. It should be fixed by this PR, but I haven't tested it: https://github.com/dolphin-emu/dolphin/pull/3673

#6 Updated by RibShark over 3 years ago

JosJuice wrote:

Actually, it seems like that change uncovered a timing bug, not just something that's a bit inaccurate. It should be fixed by this PR, but I haven't tested it: https://github.com/dolphin-emu/dolphin/pull/3673

I just tested the PR, and it seems load times are back to what they were before 4.0-8919.

#7 Updated by Fog over 3 years ago

#8 Updated by Fog over 3 years ago

#9 Updated by Fog over 3 years ago

  • Status changed from Fix pending to Duplicate

Combining all related issues into a single issue

#10 Updated by Fog over 3 years ago

#11 Updated by Fog over 3 years ago

#12 Updated by Fog over 3 years ago

  • Status changed from Duplicate to Fix pending

#13 Updated by AdahanFall over 3 years ago

The PR fixes the issue I was having as well with the Spongebob game.

#14 Updated by JosJuice over 3 years ago

  • Status changed from Fix pending to Fixed

#15 Updated by JosJuice over 3 years ago

Also available in: Atom PDF