https://bugs.dolphin-emu.org/https://bugs.dolphin-emu.org/favicon.ico?12016-03-07T05:42:44ZDolphin bug trackerEmulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7242652016-03-07T05:42:44ZMayImilae
<ul></ul><p>Can you bisect to find when it stopped working?</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7242662016-03-07T06:00:33ZHelios
<ul></ul><p>If you're on windows and can't (easily) use git bisect, use this <a href="https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds" class="external">https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds</a></p>
<p>And yes, please bisect this.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7242672016-03-07T06:03:38ZASSympt0tedentonposs@gmail.com
<ul></ul><p>4.0-8327 broke it</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7242682016-03-07T06:03:48ZASSympt0tedentonposs@gmail.com
<ul></ul><p><a href="https://dolphin-emu.org/download/dev/cc3dc05438b9324075c873cc42e72fd465b04990/" class="external">https://dolphin-emu.org/download/dev/cc3dc05438b9324075c873cc42e72fd465b04990/</a></p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7242692016-03-07T06:05:04ZASSympt0tedentonposs@gmail.com
<ul></ul><p>ASSympt0te wrote:</p>
<blockquote>
<p><a href="https://dolphin-emu.org/download/dev/cc3dc05438b9324075c873cc42e72fd465b04990/" class="external">https://dolphin-emu.org/download/dev/cc3dc05438b9324075c873cc42e72fd465b04990/</a></p>
</blockquote>
<p>Sorry, wrong link<br>
<a href="https://dolphin-emu.org/download/dev/cb5be45f728ae282177c31daded54fbce1e5285f/" class="external">https://dolphin-emu.org/download/dev/cb5be45f728ae282177c31daded54fbce1e5285f/</a></p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7242702016-03-07T08:13:12Zdegasuswickmarkus86@gmail.com
<ul></ul><p>May you check your configuration value for the option "TimingVariance"? It should be 40ms. In this case, this PR has (almost) no effect.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7242722016-03-07T14:18:53ZASSympt0tedentonposs@gmail.com
<ul></ul><p>It's 40. I tried changing it around from 10 to 100 and they all have the issue.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7242732016-03-07T14:22:29ZASSympt0tedentonposs@gmail.com
<ul></ul><p>Chaning MAX_SAMPLES back to 2048 instead of 4096 stops it from happening</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7243072016-03-11T21:56:20ZJMC4789JMC4789@gmail.com
<ul><li><strong>Assignee</strong> set to <i>degasus</i></li><li><strong>Priority</strong> changed from <i>Normal</i> to <i>High</i></li><li><strong>Milestone</strong> set to <i>Current</i></li></ul><p>Please investigate this, degasus.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7243832016-03-16T14:11:48ZFogchristhecoolist@gmail.com
<ul></ul><p>Does this audio crackling happen on a real Wii?</p>
<p>I'd like to get this confirmed before we change something which isn't correct.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7243942016-03-18T02:30:43ZFogchristhecoolist@gmail.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Accepted</i></li></ul> Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7243952016-03-18T03:25:18ZJMC4789JMC4789@gmail.com
<ul></ul><p>Can confirm the audio crackle doesn't happen on Wii.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7244002016-03-18T03:33:43ZFogchristhecoolist@gmail.com
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Fix pending</i></li></ul><p>Fixed in PR 3739: <a href="https://github.com/dolphin-emu/dolphin/pull/3739" class="external">https://github.com/dolphin-emu/dolphin/pull/3739</a></p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7244132016-03-18T16:58:26Zdegasuswickmarkus86@gmail.com
<ul><li><strong>Status</strong> changed from <i>Fix pending</i> to <i>Accepted</i></li><li><strong>Assignee</strong> deleted (<del><i>degasus</i></del>)</li><li><strong>Priority</strong> changed from <i>High</i> to <i>Normal</i></li></ul><p>The bisect is wrong, this commit makes the stutter worse, but it's not the source of the issue. AI sends more DMA samples than expected, likely because of the homebrew very often enables / disabled DMA streaming: <a href="https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/HW/DSP.cpp#L432" class="external">https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/HW/DSP.cpp#L432</a></p>
<p>So the linked patch is wrong.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7244202016-03-20T19:09:39ZJosJuice
<ul><li><strong>Milestone</strong> deleted (<del><i>Current</i></del>)</li></ul><p>Unless this affects more than some homebrew, I don't think it should be a 5.0 blocker.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7246552016-04-08T14:09:32ZJMC4789JMC4789@gmail.com
<ul><li><strong>Milestone</strong> set to <i>Current</i></li></ul><p>Until we know what we're doing wrong on this, it'd be nice to keep it current as there are games suffering from stuttering.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7246562016-04-08T14:12:43ZJMC4789JMC4789@gmail.com
<ul><li><strong>Milestone</strong> deleted (<del><i>Current</i></del>)</li></ul><p>Okay degasus explained why current was dropped.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7246572016-04-08T14:15:53Zdegasuswickmarkus86@gmail.com
<ul></ul><p>About the issue: We send the correct amount of samples triggered by coretiming. But within <a href="https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/HW/DSP.cpp#L432" class="external">https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/HW/DSP.cpp#L432</a> , we also send samples on enable/disable the DMA. So if a game enables/disables very often, we send more samples than expected. No idea if this line is just wrong, or if we need to restart the coretiming event on every enable/disable action.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7248082016-04-26T09:49:59ZJMC4789JMC4789@gmail.com
<ul></ul><p>This looks like the same bug affecting neogeo games.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7248092016-04-26T09:53:03ZJMC4789JMC4789@gmail.com
<ul></ul><p>I tried the PR that seemed to fix this and it didn't affect the neogeo titles unfortunately.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7248182016-04-26T11:54:05ZASSympt0tedentonposs@gmail.com
<ul></ul><p>I don't think it is the same bug. This affects LLE and HLE, neogeo bug is exclusive to HLE.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7248252016-04-27T00:49:12Zphirephiren@gmail.com
<ul></ul><p>I'm pretty sure loading samples on enable/disable DMA is correct, but I think the AudioDMACallback which runs at 4khz needs to have it's phase adjusted to match the timing of enabling the DMA. </p>
<p>If the homebrew is ignoring the Audio DMA interrupt + latching for correct timing (which will quickly force any game into whatever phase that dolphin chooses) and is using timers to manually trigger the Audio DMA at the correct time... you could get issues.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7248312016-04-27T03:26:51Zphirephiren@gmail.com
<ul></ul><p>So... I've looked into this.</p>
<p>Dolphin currently latches the new values onto the Audio DMA at the start of a new transferer. Because this Homebrew hasn't updated the buffer, dolphin goes back to the start of previous buffer and loads the entire thing (512 samples). Then dolphin fires the Audio DMA interrupt. </p>
<p>The game sees this interrupt and stops the Audio DMA, loads the new address into it and starts a new transfer.</p>
<p>I've experimented and it looks like the re-latching interrupt is meant to fire soon enough that this homebrew can successfully restart the DMA at a new address before any samples are read out of memory.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7450642022-10-24T18:21:02Zpokechu22
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-3 priority-2 priority-default closed" href="/issues/12281">Emulator Issues #12281</a>: Missing MaxPlay menu music</i> added</li></ul> Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7450652022-10-24T18:27:47Zpokechu22
<ul><li><strong>Fixed in</strong> set to <i>5.0-17716</i></li></ul><p>Based on <a href="https://github.com/dolphin-emu/dolphin/pull/10741#issuecomment-1152992051" class="external">https://github.com/dolphin-emu/dolphin/pull/10741#issuecomment-1152992051</a> and my own testing, this should be fixed by <a href="https://dolphin-emu.org/download/dev/4787b25a7f2acfb36a1e49a663c433640e6e3527/" class="external">https://dolphin-emu.org/download/dev/4787b25a7f2acfb36a1e49a663c433640e6e3527/</a>.</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7450662022-10-24T18:28:44Zpokechu22
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-7 priority-2 priority-default" href="/issues/12498">Emulator Issues #12498</a>: Syobon Action Wii (Homebrew) Doesn't Work</i> added</li></ul> Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7450682022-10-24T18:28:48Zpokechu22
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-7 priority-2 priority-default" href="/issues/12799">Emulator Issues #12799</a>: Rick Dangerous Wii - Doesn't Boot</i> added</li></ul> Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7457022022-12-26T02:33:04ZZephyrSurfer
<ul></ul><p>Was the status of this ticket supposed to be set to Fixed or is there more to investigate here?</p>
Emulator - Emulator Issues #9410: Audio Crackling in Homebrew Demo, not present on 4.0.2https://bugs.dolphin-emu.org/issues/9410?journal_id=7457042022-12-26T02:35:34Zpokechu22
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Fixed</i></li></ul><p>Pretty sure I meant to set this to fixed, yeah.</p>