Emulator

Is there a reliable bisect for this?

How does the controller input work with netplay anyways?

I'd think it would work like this:

• Every player sets the input we wants to use, to what he wants.
• All other inputs are set to disabled by the players
• If 2 players want to use the same slot, refuse to start
• Internally set all remote inputs to a dummy input, that only receves via netplay. This dummy input doesn't know what the actual input is on the other side, nor does it matter.
• Internally set all other inputs to disabled

Now, if netplay with the wii u adapter and emulated gamecube controllers works seperately, there's no reason to not work in a mixed setup. At least i fail to see how that could be possible.

mimimi wrote:

How does the controller input work with netplay anyways?

I'd think it would work like this:

• Every player sets the input we wants to use, to what he wants.
• All other inputs are set to disabled by the players
• If 2 players want to use the same slot, refuse to start
• Internally set all remote inputs to a dummy input, that only receves via netplay. This dummy input doesn't know what the actual input is on the other side, nor does it matter.
• Internally set all other inputs to disabled

That's how it should work (except for making player select the pad number beforehand which is terrible for usability),

My take on how it currently works is:

• Every player sets the N-first inputs to the N number of controller(s) they want to use
• In the netplay UI, the host selects the number of controllers and how each user:pad is assigned
• Internally all enabled inputs except the N first are set to Standard GC controllers, and a static var in the netplay client keeps track of the mapping
• In-game, netplay functions are called on local controller poll event (Netplay_InGamePadToLocalPad, Netplay_GetInput), the first one one will be used to detect which controller it should output the rumble to (which fails with different input devices since it calls the rumble for standard controller, and not the other such as the adapter) ; the second one sends the local input if the controller is a local one (mapped with LocalPadToInGamePad) and buffers them for the relevant in-game controller as well, then read the buffered input for the current controller (the one at that position in-game).

And now my head hurts thanks to this mapping, once again.

@Fog: the bisect is most likely when HdkR cleaned up the way adapters are handled, like all of the other adapter/netplay issues

https://github.com/dolphin-emu/dolphin/pull/3792

Does this PR have any affect?

Fixed by 4.0-9251. https://dolphin-emu.org/download/dev/3df4b09a9428fe08a8ca76502e96992ca96cfe2c/