Project

General

Profile

Emulator Issues #9453

The Legend of Zelda: Collector's Edition NES games broken again (RealXFB)

Added by JMC4789 over 3 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?

The Legend of Zelda: Collector's Edition - PZLE01

What's the problem? Describe what went wrong.

RealXFB is no longer fixing the NES games in interlaced mode. There are very obvious black lines across the screen (which, probably could be correct? I don't know.) but more seriously the lower left hand of the screen has various garbage.

What steps will reproduce the problem?

Load the game without progressive scan. Select Zelda 1/2 in the menu.

Which versions of Dolphin did you test on? Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?

I will bisect later, but, it was working when magumagu originally added support for something or another. I can't remember now. Verified broken in 4.0-9154

What are your PC specifications? (CPU, GPU, Operating System, more)

Core i5 3570K, GTX 760, Windows 10

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)

PZLE01-57.png (61.9 KB) PZLE01-57.png JMC4789, 03/26/2016 02:48 PM
PZLE01.dff (1.11 MB) PZLE01.dff seapancake, 04/06/2016 09:59 AM
PZLE01-4.png (890 KB) PZLE01-4.png seapancake, 04/06/2016 10:04 AM
5340
5360

History

#1 Updated by seapancake over 3 years ago

  • File PZLE01-1.png added

I can't even get it to load the title screen proper size, exactly the same in 4.0.2-4573.

#2 Updated by JMC4789 over 3 years ago

It requires RealXFB

#3 Updated by seapancake over 3 years ago

It was doing that (and other weird things) with Real XFB, tested it again on 4.0-9168 and it's showing same output as your screenshot...no idea why as I cleared the profile directory in both tests.

Testing again in 4.0.2-4573 shows it rendering correctly, bisected to https://github.com/dolphin-emu/dolphin/pull/2686

#4 Updated by JMC4789 over 3 years ago

  • Status changed from New to Accepted
  • Assignee set to booto

Yay, now I don't have to bisect!

#5 Updated by JMC4789 over 3 years ago

If it wasn't clear, thank you so much for bisecting it.

#6 Updated by JMC4789 over 3 years ago

  • File deleted (PZLE01-1.png)

#7 Updated by phire over 3 years ago

Found it,

the force progressive code is kicking in on what is clearly not a interlaced framebuffer.

#8 Updated by phire over 3 years ago

Fixed in PR 3753.

#9 Updated by phire over 3 years ago

  • Status changed from Accepted to Fix pending

#10 Updated by JosJuice over 3 years ago

  • Status changed from Fix pending to Fixed
  • Regression changed from No to Yes

#11 Updated by seapancake over 3 years ago

Seeing title screen corruption, seems unrelated but just wanted to confirm. Tested with progressive scan and RealXFB in 1x IR. FIFO log attached, happy to log another issue if required.

#12 Updated by JMC4789 over 3 years ago

Are you using D3D? If so, it's a bug in NVIDIA.

#13 Updated by seapancake over 3 years ago

5360

Most frames it renders fine however it flickers to this every few seconds.

#14 Updated by JMC4789 over 3 years ago

Yep, that's an unfixable bug and has nothing to do with Dolphin.

#15 Updated by seapancake over 3 years ago

Looks like it's D3D specific so I assume it's the driver bug you're referring to above? Is this something we can add to the Wiki for Nvidia users?

#16 Updated by JMC4789 over 3 years ago

It's a bug in the driver: I have no idea. It's one of those things where I have no idea what to do with it.

Also available in: Atom PDF