Project

General

Profile

Actions

Emulator Issues #9466

closed

DVDThread stores CoreTiming event int in savestates

Added by JosJuice about 8 years ago. Updated about 8 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

DVDThread's DoState function includes s_callback_event_type, which is a CoreTiming event ID. Such IDs are not guaranteed to be consistent between runs (or at least not Dolphin versions), so they should not be in savestates. This problem was introduced in DVDInterface by 4.0-5531 and moved to DVDThread later.

Actions #1

Updated by JosJuice about 8 years ago

  • Status changed from New to Fix pending
Actions #2

Updated by Fog about 8 years ago

  • Status changed from Fix pending to Fixed

Merged into latest master.

Actions #3

Updated by JosJuice about 8 years ago

Include the specific version when marking issues as fixed, please. In this case, it's 4.0-9217: https://dolphin-emu.org/download/dev/4d864ece2728a54edd9ca738d0d6ef4b219f9e20/

Actions

Also available in: Atom PDF