Emulator Issues #9573
closedSavestates created while recording a Wii game don't save whole filesystem state
0%
Description
Basically, savestates save and restore "/tmp"... but never touch anything else, even when you're recording. Therefore, it's easy to cause a desync with a recording that loads a in-game save: if you try to continue from a savestate, the save data will be missing. Generally affects every Wii game which supports saves. Probably easy to fix.
Example of how to reproduce this, for completeness:
- Start recording Twilight Princess Wii
- Press A+B to start, click yes to the "create a new memory file" prompt, start a new file
- Make a savestate
- Press home, reset, then go through to the save screen; "create a new memory file" doesn't appear
- Stop recording, save the recording.
- Load the recording, and load the savestate.
- Let recording play through to the save screen
- Observe desync: the "create a new memory file" prompt appears
Updated by phire over 8 years ago
I think this is by design as dolphin also doesn't save the memory cards in the savestate for gamecube games.
The same reproduction steps can be used there.
Though, I'm unsure of the wisdom of this design decision
Updated by phire over 8 years ago
- Status changed from Fix pending to New
No it isn't. Read the bug report better
Updated by magumagu9 over 8 years ago
The savestate code for GC memory cards special-cases movies; see https://github.com/dolphin-emu/dolphin/blob/5e50c37c138e28821079c165b0cd72702ff9154f/Source/Core/Core/HW/EXI_DeviceMemoryCard.cpp#L510 and https://github.com/dolphin-emu/dolphin/blob/5e50c37c138e28821079c165b0cd72702ff9154f/Source/Core/Core/HW/EXI_DeviceMemoryCard.cpp#L239 . It's a little tricky to set up because "Start Recording Input" puts you into the wrong mode by default. but it appears to work otherwise.
Updated by JMC4789 over 8 years ago
Wii Games really don't work well at all with savestates. I've crashed Dolphin outright by having HID devices connected during a load-state.
I have a feeling savestates need to be completely rethought on Wii; simply loading a savestate for a game as you boot the game will usually crash the game, crash audio or crash Dolphin.
Updated by JMC4789 over 7 years ago
- Is duplicate of Emulator Issues #10448: Savestates are not deterministic added
Updated by JosJuice over 7 years ago
- Is duplicate of deleted (Emulator Issues #10448: Savestates are not deterministic)
Updated by leoetlino over 7 years ago
- Status changed from New to Accepted
In my opinion, savestates should save the whole state, including the NAND filesystem, but this would make states a bit larger... On the other hand, not including the NAND will cause various issues and inconsistencies.
Updated by leoetlino almost 7 years ago
- Status changed from Accepted to Work started
- Assignee set to leoetlino
I have a WIP branch that saves the entire filesystem. I'll open a PR when it's ready
Updated by JMC4789 about 2 years ago
- Has duplicate Emulator Issues #7425: Wii TASing desyncs with saves added
Updated by JosJuice almost 2 years ago
- Status changed from Work started to Fixed
- Fixed in set to 5.0-17850