Emulator

Hmmmmm, I think the mix of 24x24 and 32x32 icons are throwing it off? So it reads a 24x24 icon and thinks the icon set should all be 24x24 and cuts off the 32x32 ones? But then, why are only two of them messed up? shrug

#wx

MaJoRoesch wrote:

Hmmmmm, I think the mix of 24x24 and 32x32 icons are throwing it off? So it reads a 24x24 icon and thinks the icon set should all be 24x24 and cuts off the 32x32 ones? But then, why are only two of them messed up? shrug

#wx

The Stop icon isn't truncated because it's smaller than the others so the visible image finishes before it gets cut off. I tried enlarging it to test it out and it appears truncated too when it is bigger.

See: http://i.imgur.com/3xvI9qM.png

You may be right about the 24 x 24 vs. 32 x 32 icons though.

Yes I think that is the issue. When the interface theme is set to Boomy the issue no longer appears.

So do I finally have a reason to make all of the icons for debug mode? I've started and stopped multiple times already. :P (I don't know what the things do so I rely on people telling me what they are, then trying to come up with ways to depict it)

MaJoRoesch wrote:

So do I finally have a reason to make all of the icons for debug mode? I've started and stopped multiple times already. :P

Heh, I was actually going to open a new issue for that next. I was going to propose creating actual debug icons and moving them into the actual themes instead of Sys/Resources as I think that is the logical way it should be done instead of what we have right now. If you are willing to work on it I think that would be a good idea to do.

MaJoRoesch wrote:

So do I finally have a reason to make all of the icons for debug mode? I've started and stopped multiple times already. :P (I don't know what the things do so I rely on people telling me what they are, then trying to come up with ways to depict it)

I have seen some good reference images online for the first few.

This page has some Metro-ish interpretations of the icons: https://blogs.msdn.microsoft.com/nikolait/2013/07/10/debugging-touchdevelop-scripts/

These are someone similar to your existing theme:

http://www.pixempire.com/icon/debug-step-into-icon.html
http://www.pixempire.com/icon/debug-step-over-icon.html
http://www.pixempire.com/icon/debug-step-out-icon.html

I do not know what Show and Set PC are supposed to look like though. Maybe a dev can find a good reference image for those.

I looked at what I have from the last time working on this, and I have images for Step Into, Step Over, Step Out, and Skip. Show PC and Set PC are the ones I could never figure out how to display. No one could really help me find a way to show it easily, and I couldn't figure it out and stopped working on it.

MaJoRoesch wrote:

I looked at what I have from the last time working on this, and I have images for Step Into, Step Over, Step Out, and Skip. Show PC and Set PC are the ones I could never figure out how to display. No one could really help me find a way to show it easily, and I couldn't figure it out and stopped working on it.

Do you know what PC stands for (I assume it doesn't mean personal computer)? The hover text for them says "Go to the current instruction" and "Set the current instruction" which sound a bit more helpful.

PC in this context is "Program Counter", i.e. the address of the current instruction.

Yep yep, that's what I had noooo idea how to display.

I am going to open a second issue report after all as this bug isn't 100% the same thing as making new icons.

Ideally new debug icons should be created but now that the Boomy theme has been otherwise removed it should be possible to fix this issue by resizing the existing Boomy icons from 24 x 24 to 32 x 32. I do not know if that might break something else however.

Fixed in #3971: https://github.com/dolphin-emu/dolphin/pull/3971

Can a project member mark this as fixed? It was fixed in Dolphin 5.0-110 as I removed the 24 x 24 icons and replaced them with 32 x 32 placeholders. The rest of the discussion is covered in the separate issue #9659.