Project

General

Profile

Emulator Issues #9681

UpdateWantDeterminism() isn't called when entering movie recording/playback by loading a savestate

Added by JosJuice over 2 years ago. Updated over 2 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-1223

Description

Game Name?

Any

What's the problem? Describe what went wrong.

When loading a savestate that has an associated DTM file (for instance, a savestate named a.sav with a DTM named a.sav.dtm), Dolphin enters movie recording or playback. However, Core::UpdateWantDeterminism() doesn't get called, meaning g_want_determinism will stay false, so parts of Dolphin can behave non-deterministically. This is the line of code where it happens: https://github.com/dolphin-emu/dolphin/blob/3570c7f03a2aa90aa634f96c0af1969af610f14d/Source/Core/Core/State.cpp#L576

What steps will reproduce the problem?

First, to create the needed files:

  1. Choose any game and use Movie > Start Recording Input to start recording a movie.
  2. When the game is running, make a savestate and save it somewhere. Dolphin will automatically create an associated DTM file.

Once you have the needed files, you can reproduce the issue:

  1. Start the game again, but this time without movie recording or playback. Just start it the normal way.
  2. Load the savestate that has an associated DTM file.
  3. If you have a breakpoint in Core::UpdateWantDeterminism(), you will now notice it doesn't trigger even though Dolphin has entered movie recording or playback.

Which versions of Dolphin did you test on? Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?

Tested on 5.0-124. I'm assuming the issue was introduced by 3a2048ea570b428ea34adbfea6b71280e1ae5cc0 since g_want_determinism didn't exist until then, but I haven't confirmed it.

History

#1 Updated by JosJuice over 2 years ago

I meant 5.0-122, not 5.0-124.

#2 Updated by JosJuice over 2 years ago

  • Milestone set to Current

#3 Updated by JosJuice over 2 years ago

  • Status changed from New to Fix pending

#4 Updated by JosJuice over 2 years ago

  • Status changed from Fix pending to Fixed
  • Fixed in set to 5.0-1223

Also available in: Atom PDF