Emulator Issues #9767: Remove warning for .dol and .elf files in game list - Emulator - Dolphin bug tracker

Actions

Copy link

Emulator Issues #9767

closed

Remove warning for .dol and .elf files in game list

Added by ryanebola16 over 8 years ago. Updated about 8 years ago.

Status:

Fixed

Priority:

Normal

Assignee:

% Done:

Operating system:

N/A

Issue type:

Bug

Milestone:

Regression:

Relates to usability:

Relates to performance:

Easy:

Yes

Relates to maintainability:

Regression start:

Fixed in:

5.0-1171

Description

Game Name?

Gecko OS

Game ID? (right click the game in the game list, properties, info tab)

N/A

MD5 Hash? (right click the game in the game list, properties, info tab, MD5 Hash: Compute)

N/A

What's the problem? Describe what went wrong.

If a .dol or .elf exists in the game list this message is displayed in the log:
"VolumeCreator.cpp:74 N[DIO]: 1SSBB Gecko.elf does not have the Magic word for a gcm, wiidisc or wad file
Set Log Verbosity to Warning and attempt to load the game again to view the values"

I don't think there's a need to warn against these files.

What steps will reproduce the problem?
Add 1SSBB Gecko.elf to the game list and load Dolphin with logs enabled.

Which versions of Dolphin did you test on? Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?

5.0-466

What are your PC specifications? (CPU, GPU, Operating System, more)

Win 10 Pro x64
Intel Core i7-4702MQ CPU @2.20GHz
GeForce GT 750M
2x 8GB Hynix 1600MHz
GeForce Game Ready Driver 372.54

Files

1SSBB Gecko.zip (407 KB) 1SSBB Gecko.zip

ryanebola16, 08/28/2016 10:03 PM

Actions

Copy link

Updated by JosJuice over 8 years ago

Status changed from New to Accepted
Easy changed from No to Yes

It's a very minor issue, but yes, this shouldn't be happening.

Currently, the code that displays that message is in DiscIO. The way DiscIO works is that if something isn't a valid volume (GameCube disc, Wii disc or WAD), it is rejected as invalid. The support for DOL/ELF files is only inside DolphinWX (or DolphinQt or whatever you're using). In other words, DiscIO currently has no idea about whether something is a DOL/ELF or not. That's why it displays that message for DOL/ELF files.

A possible solution would be to move the log message to DolphinWX (and DolphinQt2, maybe Android too if we want it there) so that it can be displayed only after checking that the file isn't a DOL/ELF. Alternatively, we could just delete it. It doesn't seem useful to me. It's easy to notice in other ways that a file is invalid (it won't show up in the game list and can't be booted), and there is very rarely any point in being able to see the magic values.

Actions

Copy link