Emulator Issues #9795: OSX Failed to build when filesystem is case-sensitive - Emulator - Dolphin bug tracker

Actions

Copy link

Emulator Issues #9795

closed

OSX Failed to build when filesystem is case-sensitive

Added by wynn1212 over 7 years ago. Updated over 7 years ago.

Status:

Fixed

Priority:

Normal

Assignee:

% Done:

Operating system:

OS X

Issue type:

Bug

Milestone:

Current

Regression:

Relates to usability:

Relates to performance:

Easy:

Relates to maintainability:

Regression start:

Fixed in:

5.0-1112

Description

Hi there.

When I trying to build dolphin-emu for OSX 10.11 I've get the following error:

[ 56%] Built target core
[ 56%] Building CXX object Externals/wxWidgets3/CMakeFiles/wx.dir/src/osx/cocoa/tooltip.mm.o
[ 56%] Building CXX object Externals/wxWidgets3/CMakeFiles/wx.dir/src/osx/cocoa/utils_base.mm.o
[ 56%] Building CXX object Externals/wxWidgets3/CMakeFiles/wx.dir/src/osx/cocoa/window.mm.o
[ 56%] Building CXX object Externals/wxWidgets3/CMakeFiles/wx.dir/src/osx/core/bitmap.cpp.o
[ 56%] Building CXX object Externals/wxWidgets3/CMakeFiles/wx.dir/src/osx/core/cfstring.cpp.o
[ 56%] Building CXX object Externals/wxWidgets3/CMakeFiles/wx.dir/src/osx/core/colour.cpp.o
/var/root/dolphin-emu/Externals/wxWidgets3/src/osx/cocoa/tooltip.mm:27:14: fatal error: 'Appkit/Appkit.h'
file not found
#include <Appkit/Appkit.h>
^
1 error generated.
make[2]: *** [Externals/wxWidgets3/CMakeFiles/wx.dir/src/osx/cocoa/tooltip.mm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Externals/wxWidgets3/CMakeFiles/wx.dir/all] Error 2
make: *** [all] Error 2

After digging around. I found case-sensitive HFS+ filesystem will cause this problem.
So doing following solved me a problem.

in Externals/wxWidgets3/CMakeFiles/wx.dir/src/osx/cocoa/tooltip.mm.o
26: #if wxOSX_USE_COCOA_OR_CARBON
27: #include <Appkit/Appkit.h>
change to
26: #if wxOSX_USE_COCOA_OR_CARBON
27: #include <AppKit/AppKit.h>

Actions

Copy link

Updated by JosJuice over 7 years ago

Tracker changed from Issue to Emulator Issues
Project changed from Infrastructure to Emulator
Regression set to No
Relates to usability set to No
Relates to performance set to No
Easy set to No
Relates to maintainability set to No
Operating system OS X added

In wxWidgets? This makes me sad :(

Actions

Copy link

Updated by BhaaL over 7 years ago

Shouldn't we rather report this to wx? We're probably faster fixing our build by just updating it, but in the long run we want to avoid patches to Externals if we can (and we just recently removed our wxAui patches).

Actions

Copy link

Updated by leoetlino over 7 years ago

This already seems to be fixed by upstream in master.

Actions

Copy link

Updated by wynn1212 over 7 years ago

Sorry for the incontinence. It looks like something does not show up.
"<" and ">" has been hide and I have no idea how to show it up.So I write here again.

in Externals/wxWidgets3/CMakeFiles/wx.dir/src/osx/cocoa/tooltip.mm.o
26: #if wxOSX_USE_COCOA_OR_CARBON
27: #include "Appkit/Appkit.h"
change to
26: #if wxOSX_USE_COCOA_OR_CARBON
27: #include "AppKit/AppKit.h"

Actions

Copy link

Updated by wynn1212 over 7 years ago

Oops! change "incontinence" to "inconvenience"

Actions

Copy link

Updated by JosJuice over 7 years ago

Issue type set to Bug
Milestone set to Current

Actions

Copy link

Updated by endrift over 7 years ago

For whatever it's worth, there is a ton of (rather important) software that breaks on case sensitive HFS+ (aka HFSX+), such as basically all Adobe products. While it's definitely a bug and it's worth fixing, HFSX+ is basically unusable for most end-users (and you have to go out of your way to create an HFSX+ volume) on OS X, so I don't think this needs to be prioritized at all.

Actions

Copy link