Project

General

Profile

Actions

Emulator Issues #9847

closed

Feature Request: Make disabling XFB set xfbreal to false too in dolphin.ini

Added by badkarma12 over 7 years ago. Updated over 6 years ago.

Status:
Invalid
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Feature request
Milestone:
Regression:
No
Relates to usability:
Yes
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

As it is now, there are currently 100 games with .ini options set to xfbenable=true and XFBReal=False in order to prevent dolphin from selecting real XFB accidentally. However, the entire option XFBReal=False is nonsensical, as why would you ever purposefully disable the most accurate setting? Dolphin doesn't actually choose randomly between the two, it actually just selects the last one used (as far as I can tell). In doing this, the xfbreal=false can be removed from every one of the ini files and enable the user to pick between the two if they so choose without editing the game settings file.

Technically speaking this whole system would be cleaner if the option was XFBVirtual instead of XFBReal, but that would take work.

Actions #1

Updated by JosJuice over 7 years ago

  • Status changed from New to Accepted
  • Issue type changed from Bug to Feature request
  • Relates to usability changed from No to Yes

I don't see how it would be cleaner by having a VirtualXFB option instead of a RealXFB option. I agree with the rest, though. (Although we should probably set RealXFB to false at runtime when XFB is disabled, instead of only setting it in the INI, otherwise people with old INIs will be screwed by this.)

Actions #2

Updated by JosJuice over 7 years ago

For future reference, we were discussing this in issue 9846 earlier.

Actions #3

Updated by badkarma12 over 7 years ago

It doesn't really matter about the virtualxfb instead, it's just good coding practice/readability. The switch should always be for the highest level feature, not the base level so that settings cannot conflict like this. Dolphin's other features are all like this. EFB copies actually used to be exactly like this.

Actions #4

Updated by JosJuice over 6 years ago

  • Status changed from Accepted to Invalid

This has become irrelevant now that the Hybrid XFB PR redid the XFB settings.

Actions

Also available in: Atom PDF