Project

General

Profile

Emulator Issues #9867

Wind Waker: Game freeze near windfall Island

Added by danebouchie about 3 years ago. Updated almost 2 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
Windows
Issue type:
Bug
Milestone:
Current
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?

THE LEGEND OF ZELDA The Wind Waker for USA

Game ID?

GZLE01

MD5 Hash?

d8e4d45af2032a081a0f446384e9261b

What's the problem? Describe what went wrong.

Game Freeze. "Invalid write to 0x1234567, PC=0x80006d68"

What steps will reproduce the problem?

  • Travel to Windfall Island after visiting Greatfish Isle (after completing Forest Haven)
  • Freeze occurs after entering Windfall Island grid location

Which versions of Dolphin did you test on? Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?

4.0-9507
5.0-1171

What are your PC specifications? (CPU, GPU, Operating System, more)

Intel i5-4570
Windows 10 x64
Nvidia GTX 970
Multi-Montior

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)

Tried with different combinations of the following:
- JIT Recompiler
- JITIL Recompiler
- DirectX 11
- DirectX 12
- Texture Cache Safe
- All EFB settings on/off

I've attached the memory card as well as the settings used. File used is File 1.

MemoryCardA.USA.zip (208 KB) MemoryCardA.USA.zip danebouchie, 10/30/2016 10:51 PM
GFX.ini (1.2 KB) GFX.ini danebouchie, 10/30/2016 11:02 PM
Dolphin.ini (8.34 KB) Dolphin.ini danebouchie, 10/30/2016 11:02 PM
gfx_dx11.ini (1.25 KB) gfx_dx11.ini danebouchie, 10/30/2016 11:02 PM
ucrtbase.dll (880 KB) ucrtbase.dll danebouchie, 10/31/2016 02:52 AM

Related issues

Related to Emulator - Emulator Issues #8930: Wind Waker freezes at Windfall IslandFixed

History

#1 Updated by danebouchie about 3 years ago

Whoops forgot to add title.

I don't think I have access to change it but, if possible, please change to "Wind Waker: Game freeze near windfall Island"

#2 Updated by pauldacheez about 3 years ago

  • Subject changed from [Short description of your bug here (~10 words)] to Wind Waker: Game freeze near windfall Island

#3 Updated by JMC4789 about 3 years ago

That looks like a cheatcode crash; you may have some kind of cheatcode on that is causing the game to crash.

#4 Updated by danebouchie about 3 years ago

JMC4789 wrote:

That looks like a cheatcode crash; you may have some kind of cheatcode on that is causing the game to crash.

I have cheats disabled in the settings, as well as no patches/codes are selected, so...

#5 Updated by JMC4789 about 3 years ago

Wait... a long time ago, I remember a weird issue with Windows + Windfall island. I'll try traveling there to see if I can reproduce the issue.

#6 Updated by JMC4789 about 3 years ago

Also try using an even older build if possible to see if it starts working at some point.

#7 Updated by danebouchie about 3 years ago

Seems to be working in 4.0-3595

#8 Updated by JMC4789 about 3 years ago

Continue to bisect, try moving closer and closer to master until it breaks again.

#9 Updated by danebouchie about 3 years ago

Found it:

Working in: 4.0-7528
Broken in: 4.0-7538

Related issue (possibly same): https://bugs.dolphin-emu.org/issues/8930

Seems the move to VS2015 caused it.

#10 Updated by JMC4789 about 3 years ago

  • Assignee set to Anonymous

yep, that's what I thought. #blame Windows.

#11 Updated by danebouchie about 3 years ago

Looks like you guys might need my ucrtbase.dll.

From the looks of https://github.com/dolphin-emu/dolphin/pull/3217 (what supposedly fixed it before) ucrtbase.dll just needs another patch.

Something along the lines of:
// 10.0.10240.117146 (th1.160929-1748)
{ L"ucrtbase.dll", 0xF86F8, ?, ?},

Tried to figure out exactly what in fseek is being patched but couldn't (rva and length), so I'll leave that to someone who knows what they're doing.

#12 Updated by JosJuice about 3 years ago

  • Milestone set to Current
  • Operating system Windows added
  • Operating system deleted (N/A)

#13 Updated by JosJuice about 3 years ago

#14 Updated by Anonymous over 2 years ago

Yea, as danebouchie said, the attached ucrtbase is:

FileVersion: 10.0.10240.17146 (th1_st1.160929-1748)

I would suggest that we remove the ghetto patching completely, and instead check if the ucrtbase is too old. If it's too old, we just complain to the user about it.
I'll probably implement that once I find out what exact version the fix shipped in.

#15 Updated by Anonymous over 2 years ago

  • Status changed from New to Work started
  • Priority changed from Normal to Low

The fix shipped in th2 10548. I think everyone should just be able to run windows update to solve this...I will look into how to detect the old versions and get people the newest one.

#16 Updated by Anonymous over 2 years ago

  • Status changed from Work started to Fixed

PR 5582 will detect if you're on an old version. If so, it will try to apply one of the existing patches dolphin had for ucrtbase. If you have an old version that dolphin doesn't know about, you'll see a warning dialog telling you to update your UCRT - which is what you should do, anyways. MS shipped the fix for this years ago so I don't plan to add any more patches to dolphin.

#17 Updated by Helios almost 2 years ago

  • Priority changed from Low to Normal
  • Status changed from Fixed to Accepted

#18 Updated by JosJuice almost 2 years ago

I wouldn't treat that forum topic as a sign of a regression... The poster is using 5.0, and PR 5582 was merged way after that.

Not sure why JMC would be getting the bug, though (assuming he's on a recent build and the UCRT error message isn't shown).

#19 Updated by JMC4789 almost 2 years ago

I may be getting it because I left the 60 FPS code on my laptop.

#20 Updated by JosJuice almost 2 years ago

  • Status changed from Accepted to Fixed

Re-closing for now.

Also available in: Atom PDF