Emulator Issues #9871
closed
After recording inputs the GC Memcard Manager throws an error on every action
0%
Description
Game Name?
GC Twilight Princess NTSC (likely doesnt matter)
Game ID? (right click the game in the game list, properties, info tab)
GZ2E01
What's the problem? Describe what went wrong.
http://image.prntscr.com/image/6960eb797aa94047bb554eed734cc254.png
What steps will reproduce the problem?
Start Dolphin
Select Game
Movie->Start Recording Input
Close Dolphin
Open Tools->Memcard Manager (GC)
Doing anything (opening mem card, importing saves, deleting saves) will throw this error
Which versions of Dolphin did you test on? Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?
Doesn't work on 5.0-1223
Updated by dragonbane over 7 years ago
ah yeah ok, looks like Core::g_want_determinism needs to be updated again to false once the game is closed to fix this
Updated by JosJuice over 7 years ago
Does this PR fix the problem? https://github.com/dolphin-emu/dolphin/pull/4420
Updated by dragonbane over 7 years ago
It does, good job! Is it a good idea though to leave want determinism on true after the game is closed? I don't know if it might affect anything else or when you start another game in non TAS mode. Plus it is a bit "dirty", but if it doesn't matter anywhere I guess its fine
Updated by JosJuice over 7 years ago
g_want_determinism is always reset when the core starts: https://github.com/dolphin-emu/dolphin/blob/d5ca153c26a9eae2084a3ff8d4a8d5cd1acf56ac/Source/Core/Core/Core.cpp#L248
So unless there's something that relies on g_want_determinism being false when the core isn't running (I'm not aware of anything that does), it shouldn't matter. But maybe it's better to reset it anyway? I'm not sure.
Updated by dragonbane over 7 years ago
I don't think there is either, but I guess it maybe should be done to avoid another issue in the future if something else is tied to it.
Updated by JosJuice over 7 years ago
- Status changed from Fix pending to Fixed
- Fixed in set to 5.0-1806