Project

General

Profile

Emulator Issues #9938

Promotional GameCube games are detected as Turbografx-16 titles with GameINI

Added by xerxes about 3 years ago. Updated about 3 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-1552

Description

Game Name?

Mario Kart: Double Dash!! Bonus Disc, The Legend of Zelda Collector's Edition, Pac-Man Vs., Pokemon Colosseum Bonus Disc, Resident Evil 4 Preview Disc, Metroid Prime 2: Echoes Bonus Disc, a Metal Gear Solid bonus disc and a Naruto bonus disc. Probably more too.

Game ID?

Did a DPL on the wiki. These are the non-VC Pxxxxx IDs that came up.

PM4E01
PZLP01, PZLJ01, PZLE01
PRJE01, PCPJ01, PRJP01
PCKJ01, PC6E01, PCSJ01
P4BJ08
PGSJ01
PNRJ01

What's the problem? Describe what went wrong.

Some bonus/promo GameCube discs have an ID starting with P, which groups them under the GameINI settings for Virtual Console Turbografx-16 titles. Currently this only turns on Texture Cache Accuracy: Safe, so it's not very damaging, but it's still unnecessary.

What steps will reproduce the problem?

1) Load promo disc like the Double Dash bonus disc.
2) Open game properties and hit Show Defaults. The Pxxxxx (P.ini) settings are incorrectly attributed.

Which versions of Dolphin did you test on? Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?

5.0-1444

History

#1 Updated by JMC4789 about 3 years ago

  • Status changed from New to Accepted

Hah. This is easy enough to fix... I think.

Actually, the P ini may override anything in the lower ones... or is it the other way around. Either way, it should be fixable one way or another.

#2 Updated by xerxes about 3 years ago

Forgot P2ME01 in that list, the Metroid Prime 2: Echoes bonus disc.

#3 Updated by JosJuice about 3 years ago

That P.ini shows up when pressing Show Defaults is not an issue that needs to be fixed. (It's unnecessarily complicated to fix - we would need to make some kind of list of either all TurboGrafx-16 games or all P bonus discs and make Dolphin handle games specially if the are/aren't on that list - and there's no real benefit to fixing it.)

If any GC discs with IDs starting with P don't have INIs that override the settings from P.ini, then that's a valid issue.

#4 Updated by JosJuice about 3 years ago

Err, I forgot it also would be possible to add a hardcoded check that skips one-letter INIs if the current game is a GC game. That's ugly, though.

#5 Updated by xerxes about 3 years ago

The only disc I have to test this which tipped me off to the problem was the Double Dash bonus disc and it does apply the settings without an override.

https://i.gyazo.com/fdd018c1cee54261d4c1efd5ebaa6a5f.png GameINIs for PM4E01
https://i.gyazo.com/f7d550732607533afef0a55896dc97ce.png Safe Texture Cache being applied

Without knowing specifics, would it be possible to make a GameINI setting with the function of "ignore more general INI settings, only use the settings in this particular file or below"? So like in this example, you could put it in PM4xxx, and it would ignore all settings from PMxxxx, and Pxxxxx. Could maybe have use for specific region versions of games that need different settings than others; have the general settings in something like G41xxx, then the specific down in G41Jxx with the override. Just spitballing here.

#6 Updated by JosJuice about 3 years ago

We currently don't have a way to do that for all settings, but it's possible to do it for single settings as far as I know, so we can put a command in PM4.ini to ignore P.ini's SafeTextureCacheColorSamples value. Some affected discs already have that in their INI.

#7 Updated by JosJuice about 3 years ago

I can't find any references to the existence of PCKJ01 on the internet other than the Dolphin wiki, and it seems unreasonable that both PCKJ01 and PCSJ01 would be used for Japanese Pokémon Colosseum bonus discs. Does anyone know anything more about this game ID?

#8 Updated by JosJuice about 3 years ago

I'm suspecting that P4BJ08 is a typo too. The equivalents for other regions start with D4B.

#9 Updated by JosJuice about 3 years ago

  • Status changed from Accepted to Fix pending

The missing INIs are added by https://github.com/dolphin-emu/dolphin/pull/4549

The behavior of Show Defaults isn't going to change. The point of Show Defaults is that it shows all INIs that get loaded, and P.ini does get loaded, so Show Defaults should show it. Not loading P.ini at all is unnecessarily complicated for the reasons I described before.

#10 Updated by PPLToast about 3 years ago

PCKJ01 is another version of the colosseum bonus disc. Rather than trailers, it contains a demo for Pokemon Channel in it. You can identify the version by looking at the sleeve the disc is in more easily but the ID is (barely) visible here at least http://leafgreen.free.fr/celebi-bonus-disc.jpg

#11 Updated by PPLToast about 3 years ago

Here's the RE4 P4BJ08 disc too http://i.imgur.com/gSrhqaZ.png

#12 Updated by JosJuice about 3 years ago

Thanks for the info. I've added those two IDs to the PR.

#13 Updated by JosJuice about 3 years ago

  • Status changed from Fix pending to Fixed
  • Fixed in set to 5.0-1552

Also available in: Atom PDF