Project

General

Profile

Actions

Emulator Issues #9999

closed

Skip BIOS checkbox is supposed to be disabled when there are no BIOS files

Added by JosJuice about 7 years ago. Updated about 4 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
5.0-1259
Fixed in:

Description

The "Skip BIOS" checkbox in the GameCube tab of the general config is only supposed to be enabled when a BIOS file is available (and the core isn't running): https://github.com/dolphin-emu/dolphin/blob/bfa9cc27361415a78ddb366764be6f929bf78d6a/Source/Core/DolphinWX/Config/GameCubeConfigPane.cpp#L74

However, https://github.com/dolphin-emu/dolphin/pull/4427/commits/bfa9cc27361415a78ddb366764be6f929bf78d6a made it so that the checkbox always is enabled as long as the core isn't running, ignoring the BIOS file check.

Actions #1

Updated by JosJuice almost 7 years ago

  • Description updated (diff)
Actions #2

Updated by JosJuice almost 7 years ago

As a note to anyone who wants to fix this: Due to https://github.com/dolphin-emu/dolphin/pull/5492#issuecomment-306988942, it should be possible to enable skipping when there's no IPL file, but it shouldn't be possible to disable skipping when there's no IPL file. (Before the 5.0-1259 regression, it was always impossible to change the setting when there was no IPL file.)

Actions #3

Updated by Billiard26 about 4 years ago

  • Status changed from New to Fixed
  • Fixed in set to 5.0-6128

This seems to have been fixed somewhere around here.

Actions #4

Updated by JosJuice about 4 years ago

  • Fixed in deleted (5.0-6128)

Yes, this is no longer a problem. The version you're pointing to doesn't seem correct, though. I'm going to assume that this is a DolphinWX/DolphinQt difference.

Actions

Also available in: Atom PDF