Project

General

Profile

Actions

Emulator Issues #10991

closed

Request to add a unscrubber to the uncompress option of dolphin

Added by i30817 about 6 years ago. Updated almost 4 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Feature request
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-12188

Description

What's the problem? Describe what went wrong.

Currently, compressing a game is a destructive operation when it could be not.

As dolphin found out long ago, to be able to compress a Wii game, you need to remove the 'random' data nintendo inserted, so reversing the inserter would make the operation lossless.

Moreover, i'm hoping that .DAT files standardize on dolphin compression checksums for scrubbed discs in order for projects like RA to end up with the right metadata, so having a complete stable solution for the scrub/unscrub roundtrip would be a good standardization advantage.

Actions #1

Updated by i30817 about 6 years ago

Description

What's the problem? Describe what went wrong.

Currently, compressing a game is a destructive operation when it could be not.

As dolphin found out long ago, to be able to compress a Wii game, you need to remove the 'random' data nintendo inserted, so reversing the inserter would make the operation lossless.

Moreover, i'm hoping that .DAT files standardize on dolphin compression checksums for scrubbed discs in order for projects like RA to end up with the right metadata, so having a complete stable solution for the scrub/unscrub roundtrip would be a good standardization advantage.

edit: even better would be to support playing games with the .iso.dec (NASOS) format, because that executable scrubs and unscubs, and there are already redump dats with their md5sums for other projects to use.

Actions #2

Updated by JosJuice about 6 years ago

  • Issue type changed from Bug to Feature request

I'm planning to add support for a format that can remove the pseudorandom data losslessly (but it might be a different format than the NASOS format - I don't think that format has any public documentation or source code). I don't know when in the future I'll get time for it, though. Adding an "unscrubber" that would be able to unscrub disc images stored in a format with no special support for the pseudorandom data (e.g. ISO, GCZ, WBFS) seems more fragile.

Actions #3

Updated by i30817 about 6 years ago

I honestly have no preference in which one gets in, only that one does and a dat exists for it.

Dec has the 'advantage' that it makes the files 'really' smaller, not just zero or 'FF' the holes which is more useful when the filesystem has support for spare files or the games are on zips (which they aren't necessarily on).

Dolphin could make me very happy by adding instrumentation collecting the md5sum before the invertible scrub, the md5sum after the scrub and upload it somewhere so it's easy to connect redump etc to the scrubbed disks. Could be useful for the wiki and bug reports too.

Actions #4

Updated by i30817 about 6 years ago

BTW, i was wondering does the typical sparse file implementation on unix filesystems works with FF as it does with 00? If no, it might be better to use '00' and maybe break 'compatibility' with some unscrubbers (that may not work anyway) on your format if you decide scrub instead of remove space.

Also it's really weird that this bug database uses 'edit' to post new replies.

Actions #5

Updated by JosJuice almost 4 years ago

  • Status changed from New to Fixed
  • Fixed in set to 5.0-12188

The format I mentioned was added in https://dolphin-emu.org/download/dev/99822518994d62def4e336f6746d6a2e2d108fb2/. Unscrubbing arbitrary disc images is complex enough that I'd rather leave the task to separate programs, like the NKit app, which seems to be doing a very good job at this already.

Actions

Also available in: Atom PDF