Project

General

Profile

Actions

Emulator Issues #1209

closed

EFB Hotkey off -> EFB leftovers on screen

Added by sskkiipp almost 15 years ago.

Status:
Invalid
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?

  1. Start a race Mario Kart Wii with efb turned on
  2. Turn off efb by hotkey
  3. See the last efb-picture the whole time :)

What is the expected output? What do you see instead?
Well, when i disable efb the picture the shouldh't be any leftovers from
efb :) there should be a function to clear the picture from this

And if someone has any idea on how to fix the black rectangle located at
height 600 when starting without efb and without turning it on feel free to
comment :) :)


Related issues 1 (0 open1 closed)

Has duplicate Emulator - Emulator Issues #1234: Force Frame ClearingDuplicate

Actions
Actions #1

Updated by Anonymous almost 15 years ago

  • Status changed from New to Questionable

silly, i don't see why so many people complain that turning off part of the graphics
subsystem results in ugly graphics :D
I can't think of a way to fix this off the top of my head, either.

Actions #2

Updated by sskkiipp almost 15 years ago

It works if efb is turned off the whole time :)

Actions #3

Updated by sl1nk3.s almost 15 years ago

"there should be a function to clear the picture from this"

yeh, it's called enable copy EFB :D

Actions #4

Updated by sskkiipp almost 15 years ago

"silly, i don't see why so many people complain that turning off part of the graphics
subsystem results in ugly graphics :D"

If you try MK Wii with EFB and Other Audio you get 60fps, but the game will be too
slow to consider it playable. One second in mk wii = ~2 sec in real life. Actually
other audio is the only way to limit the frames the right way. So turning off efb ist
the only way. I can only guess, but i thing the CPU is yielded to much with efb and
other audio. damnn _mm_pause()

Actions #5

Updated by Anonymous almost 15 years ago

"And if someone has any idea on how to fix the black rectangle located at
height 600 when starting without efb and without turning it on feel free to
comment :) :)"
-> probably not "fixable"

"It works if efb is turned off the whole time :)" -> oh, I thought there was some
other glitch if it was off the whole time? If not, then yes, we could probably could
clear the effected area. (but still, wouldn't we all rather have it work correctly
and speedy instead? :p )

Actions #6

Updated by sskkiipp almost 15 years ago

Ok, i see that :) plz read my post before :) efb + other audio = 60fps but unplayable
:) any idea :)

last but no least : is there a reason the lock threads to cores option is there?

Actions #7

Updated by Anonymous almost 15 years ago

"is there a reason the lock threads to cores option is there?"
Apparently some cpus (mobile?) have pretty big slowdowns with it either on or
off...forget which way :p. If you look to the revision it was added, you'll probably
find out.

as to the high fps but slow speed...I'm not sure...I can only generally say that it
probably has to do with nolan check's recent changes to threading/framebuffers/etc.

maybe he can say more :p

Actions #8

Updated by sskkiipp almost 15 years ago

Maybe :) But his changes didn't seem to change anything. I noticed this earlier :)

as of "lock threads to cores" : i have slowdowns with on, since i have a quadcore :)
if its off i get a cpu usage around 75% and fast, on 50% and slow. I'm just asking,
cause evrybody on the forums always turns its on which is a dumb thing to do. I'll
vote for removing it :)

"Setting an affinity mask for a process or thread can result in threads receiving
less processor time, as the system is restricted from running the threads on certain
processors. In most cases, it is better to let the system select an available
processor." http://msdn.microsoft.com/en-us/library/ms686247%28VS.85%29.aspx

Actions #9

Updated by Anonymous almost 15 years ago

hm so the speed issue has always been around?

Actions #10

Updated by sskkiipp almost 15 years ago

in MK Wii with efb and other audio : YES!
not sure about other games. Since there is no time shown there to check :)

btw: i'm just removing the Warnings while compiling. Interested in a patch ?

Actions #11

Updated by sskkiipp almost 15 years ago

hmm, it seems that removing the warnings is just changing Implicit conversion to explicit

Actions #12

Updated by Nolan.Check almost 15 years ago

Is this issue about graphics or frame rate...or what?

"Copy EFB to RAM (real)" is the only way to get correct behavior. I was even thinking
of removing the option to switch it off. But it seems that some graphics cards can't
copy to RAM very fast. I think it should at least be enabled by default.

I doubt that _mm_pause would actually cause a major slowdown. If you want, you can
just change the "YieldCPU" function in Common/Thread.h to do nothing at all. See if
it makes any difference.

Actions #13

Updated by marcus almost 15 years ago

Issue 1234 has been merged into this issue.

Actions #14

Updated by ayuanx over 14 years ago

  • Status changed from Questionable to Invalid

Always remember: "EFB to texture" is a HACK. So is "EFB copy off".

Actions

Also available in: Atom PDF