Emulator Issues #2964
closed
Savestates are extremely unstable in recent revisions
Added by wespipes69 almost 14 years ago.
Relates to performance:
No
Relates to maintainability:
No
Description
What steps will reproduce the problem?
- With a fresh install, launch a game and perform a savestate on any type of game (GC, Wii).
- Load the state. Perform this in the menus and in game just a couple of times.
What is the expected output? What do you see instead?
Dolphin crashes after a couple saves (if not the first). F-Zero does a weird thing where you try to load a state and it simply reboots the game if it can't load the state properly. Maybe a clue?
Dolphin version with the problem? Other Dolphin version without the
problem?
I'll have to investigate...unless this is a known issue and the devs know what's going on with this.
32-bit or 64-bit and any other build parameters?
64bit.
OS version and versions of tools/libraries used?
Win 7
Please provide any additional information below.
--None of the logs catch anything.
--This occurs with a complete fresh install with everything default.
--This has been a problem for a couple of months I would have to say.
--Anyone else? I'm surprised this hasn't come up lately.
Just confirmed this occurs the same on both 32bit and 64bit Dolphins. I can launch a game like RE4 and after 2 save/loads, the emu will simply crash. States used to be extremely stable for a very long time until just recently.
Hopefully I'm not the only one, since i have the problem with both 32 and 64bit Dolphins with just default settings. Maybe one those default settings is contributing to this?
r5841 might be the cause. Can you test r5841 and r5840 to be sure? Let me know.
HEY!!! You hit the nail right on the head!! I loaded up 40 and could repeatidly do save states forever. I then loaded up 41 and sure enough crash on the very first save! That's unquestionably the cause. Looks like the icache needs some changes. So states have been broken for 150 revisions and I'm the first to bring it up?! :) Oh well, at least it'll be good to have them back finally. Thanks for tracking that down and for the eventual correction. Thanks!
- Status changed from New to Accepted
Thank you for the response and quick turn-around. I will put this issue to the top of my list of things to do after my next commit. I hope I know how to fix it...
Issue 2976 has been merged into this issue.
wespipes69, which game did you test it on? Was it F-Zero GX? I looked at the save state code and it seems like save states should already be working for all games except F-Zero.
No, this was with numerous games, including NSMB, RE4 wii, and many others. Just tried 5991 a couple minutes ago and after the 2nd savestate, the emulator crashed. There's still something definetely wrong in the code introduced in r5841. Are you getting no crashes when performing 2+ save states in games?
Happens on GC as well as Wii games for the record. All the Mario Parties also crash when using states.
I've just made r5840 crash by pressing shift f1, shift f2, f1, f1, f2, f1 in mkdd. I don't think r5841 is the cause because I've checked and double checked that code and it is save state compliant.
Your right. Apologies, didn't do enough thorough testing and the results were somewhat random to begin with.
BUT, I figured it out. It's another stability issue related to having dual core and vsync enabled. See Issue 2982 - you might just want to merge this into that as all the characteristics are the same but the revisions that broke these 2 items are definetely different.
For this save issue, it was r5777 that broke states with these functions active. There, done. Out of my hands - this has taken forever to accurately nail down!! :)
- Status changed from Accepted to Fixed
This issue was closed by revision r6000.
Also available in: Atom
PDF
Updated by 
Updated by