Emulator Issues #3123
closed
Broken fog effects in Metroid Prime by r6056 "Set z-position for opengl"
0%
Description
What steps will reproduce the problem?
There are no specific steps to reproduce the problem just use OGL.
(Not sure but this can also happen with D3D)
What is the expected output? What do you see instead?
The expected output is correct fog.
Instead I see these issues:
http://www.abload.de/img/fog6lk0j.png
http://h-3.abload.de/img/fog3we6k.png
http://h-3.abload.de/img/fog2oh8x.png
http://h-3.abload.de/img/fog4hcri.png
http://www.abload.de/img/fog1heq9.png#
Dolphin version with the problem?
Very old revisions have the issue.
Then the issue has been fixed by a revision I don´t remember.
Revision r6056 "Set z-position for opengl" broke it again.
32-bit or 64-bit and any other build parameters?
I´m using Vista x64 with Dolphin x64.
Updated by pierre over 13 years ago
This was already broken in r5895, probably "fixed" by r5896, which started to use the broken depth result from the vertex shader instead of the correct(?) one from the pixel shader. r6056, r6061 and r6078 modified the depth calculation in the vertex shader to give the same result as the calculation in the pixel shader.
I compared the results of r5895, r6055 and r6078 against a youtube video captured from the real game at the place visible in fog1heq9.png, and none of them were correct.
r5895 showed "depthbanding"(i.E. abrupt change of fogginess visible on the walls)
r6055 shows too few fog, the far door should be much more grayish
r6078 is similar to r5895 again
One of the bands in r5895/r6078 looks right, but the banding is still wrong.
Updated by pierre over 13 years ago
Please try r6217 which should fix this issue.
Updated by Nick.Lustig over 13 years ago
I have rechecked the issue with r6269 and I can say it´s 99% fixed,
you need a loupe and very good eyes to see the remaining graphical issue.
I would say you can put the Status to fixed, good job pierre :)
Updated by pierre over 13 years ago
- Status changed from New to Fixed
Well, i guess thats good enough. Fixed by r6217.