Project

General

Profile

Actions

Emulator Issues #4265

closed

ESC should close all dialogs

Added by NeoBrainX over 13 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Category:
UI
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
Yes
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?

  1. Open the general config, press ESC
  2. Open the video config, press ESC

What is the expected output? What do you see instead?

Both should be closed after pressing ESC (about all usual dialogs behave like that), but only the general config dialog closes. There's several other dialogs in Dolphin which do not get closed after pressing ESC which isn't exactly consistent behavior...


Related issues 1 (0 open1 closed)

Blocks Emulator - Emulator Issues #4270: Dolphin 3.0 bug trackerFixedNeoBrainX

Actions
Actions #1

Updated by glennricster over 13 years ago

To fix this we just have to use wxID_OK instead of (or in addition to) using whatever id we are using to close the dialog.

Actions #2

Updated by glennricster over 13 years ago

  • Status changed from New to Fixed

This issue was closed by revision r7365.

Actions #3

Updated by William79371 over 13 years ago

Thanks a lot!

Actions

Also available in: Atom PDF