Emulator Issues #4388
closed
Revision 7328 break red steel 1 save feature
0%
Description
What's the problem?
Red steel 1 save failure after revision 7328.
Although, the game freeze in game that another problems.
But save failure also means there is some problems in 7328 revision.
I hope someone can take a look on it.
Dolphin version with the problem (as it appears in the title bar, Ex.: "R
4779" or "R 6403M"):
7328
(optional) Dolphin version that does not have the problem:
All revision before 7328
Operating system and version:
32-bit or 64-bit:
64bit
Game ID (as it appears in game properties, Ex.: "GZ2P01" or "RSBE01"):
REDE41
Build command-line (not on Windows):
Was the ISO a plain dump from disc, compressed and/or scrubbed?
plain dump
Please provide any additional information below.
Updated by DimitriPilot3 over 13 years ago
- Relates to usability set to Yes
So you are saying that it worked on r7327 and broke in r7328, huh? Does the problem persist using Mamario's (official) 32-bit builds?
Updated by blackjade.gm over 13 years ago
Yes, I can confirm that both x86 and x64 worked on r7327 and broken after r7328.
The game show save failed in r7328:
http://img850.imageshack.us/img850/9510/rede411.png
Updated by blackjade.gm over 13 years ago
Another new issue occur..
The game can boot up without crashing on r7473 but crashing after r7474.
May be also affect other games...
Updated by blackjade.gm over 13 years ago
In conclusion, r7328 broke the save feature and r7474 crash the game after boot up.
Updated by DimitriPilot3 over 13 years ago
Just compiled a Windows x86 build of r7435, with the changes to WII_IPC_HLE_Device_FileIO (both .cpp and .h) from r7328 reverted, plus some other modifications that shouldn't be irrelevant to this issue:
http://www.mediafire.com/?h9czf6zur4obu6k
Could you try saving the game using this build? Did reverting these changes fix it for you?
Updated by BhaaL over 13 years ago
Can someone try and add "std::fflush(m_File);" to before "return m_good;" inside FileUtil.h at IOFile::WriteArray?
shuffle suggested it might be an internal buffering that causes problems on subsequent reads. I don't have Red Steel and can't test this.
Updated by blackjade.gm over 13 years ago
DimitriP...@gmail.com's build work and the problem fixed.
Tried add "std::fflush(m_File);" before "return m_good;" in FileUtil.h not work...
So, the problems is inside WII_IPC_HLE_Device_FileIO?
Updated by BhaaL over 13 years ago
The code should be equivalent; the only thing I noticed was that Device_FileIO::Write was changed from fwrite(buf, size, 1, fp) to fwrite(buf, 1, size, fp). Everything else should in theory perform the same way...
I could't reach Billiard yet, the only other thing that came to mind was the direct use of fread somewhere inbetween, while he did make a method IOFile::ReadBytes that could do the same.
Updated by Anonymous over 13 years ago
- Status changed from New to Fixed
This issue was closed by revision r7502.
Updated by marduk222 over 13 years ago
at rev7554 the game Run, but on the beging the player don't turn around with a wiiremote emulate