Project

General

Profile

Actions

Emulator Issues #5419

closed

use of deprecated ffmpeg functions

Added by jesse.jaara over 12 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Expectation)
Building with a modern git version of libav/ffmpeg results in succes

What happens)
Make complains about deprecated API usage and exists with error.

atlest avcodec_open should be replaced with avcodec_open2 and av_new_stream with avformat_new_stream. More might exist deeper in the code.

avcodec_encode_video is still presented in libav but as deprecated, should be replaced with avcodec_encode_video2

More info: http://ffmpeg.org/doxygen/trunk/deprecated.html

Actions #1

Updated by delroth over 12 years ago

Do you know what version of ffmpeg/libav introduced these new functions and if it is safe to assume that everyone will be able to compile Dolphin if we're using avcodec_open2?

Actions #2

Updated by jesse.jaara over 12 years ago

This was backported to 0.7.3 libav, I think it has been in the git since july 2011

Actions #3

Updated by delroth over 12 years ago

I'm not sure how I feel about making Dolphin impossible to compile without a recent ffmpeg version. Maybe we should check for the existence of the functions and disable the frame dumping ability when running cmake.

BTW, the deprecated functions should not cause a compilation error (only warnings), what compiler are you using and are you using the default compilation CXXFLAGS?

Actions #4

Updated by UraharaKisuke153 over 12 years ago

I think without the libav/ffmpeg frame skipping is disabled.

Actions #5

Updated by delroth about 12 years ago

  • Status changed from New to Fixed

Fixed by rc1a684bd44a1.

Actions

Also available in: Atom PDF