Emulator Issues #5422
closed
Code review request: hires-texture-improvements
0%
Description
Purpose of code changes on this branch:
Various improvements targeted at improving hires texture packs for Dolphin:
- Support dumping all LODs (filenames will be suffixed with _mipX) rather than only the most detailed mipmap level.
- Support loading custom LODs. This very much makes sense because native mipmaps can't be used for hires textures (texture sizes don't match) but autogenerating mipmaps causes issues in some games. Also, some really cool effects can be achieved via custom LODs.
- Remove the size restriction of custom textures. Many native textures already have a width of 1024. Since the maximum width was 2048 previously, it was merely possible to have twice as many horizontal pixels. Any GPU supporting D3D10 can handle a texture width of 8192, so the removal of that limitation sounded reasonable.
When reviewing my code changes, please focus on:
- Any regressions concerning games which are sensitive to mipmap emulation bugs (I only tested super mario sunshine's water so far)
- Testing the new features. I'll likely require feedback from someone who actually creates a hires texture pack for this one.
After the review, I'll merge this branch into:
master
Updated by NeoBrainX almost 13 years ago
Btw, I should probably mention that both dumping and loading custom LODs require "fast mipmaps" to be disabled. I'm not sure if I'll further document this somewhere, because that setting is staged for removal anyway.
Updated by burnhellxp almost 13 years ago
When you are playing a game with many custom textures, dolphin always lag, when it need load many custom textures.
There is a possibility to fix it?
Updated by burnhellxp almost 13 years ago
BTW, this "load custom texture lag" issue, it always happens with RE4.
Neo, is possible, make dolphin load custom textures without lags?
Updated by NeoBrainX almost 13 years ago
Are you referring to worse performance or to stuttering when you say "lag"?
Updated by burnhellxp almost 13 years ago
Stuttering, the game freeze for a time (because it is loading the textures) depending on the amount of texture and the resolution of texture, of it's loading, it can take about 7 seconds frozen.
Load custom textures never worse performance here, even with old video cards.
Updated by NeoBrainX almost 13 years ago
Yeah, we're doing lots of stupid stuff when loading custom textures. It's probably easy to fix that, but possibly a pretty time-consuming task. Not sure if I'll take a stab at it.
Updated by TymunXit almost 13 years ago
Mipmaps and 8192 textures loading fine.
Performance doesn't seem to be affected by the high resolutions, but the game indeed hangs a bit when loading them, luckily SMSS does that only when you start a new level or enter a new area(caves, the Hotel, the amusement park) so the gameplay's not being affected by the texture loading.
Updated by NeoBrainX almost 13 years ago
Merged since revision 4131ca8d386e.
Thanks for reviewing + testing ;)
Updated by