Project

General

Profile

Actions
Copy link

Emulator Issues #5542

closed

trunk fails to build with wxWidgets 2.9.4

Added by cristian over 12 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

trunk fails to build with wxWidgets 2.9.4, patch attached.

Actions
Copy link
 #1

Updated by delroth over 12 years ago

  • Status changed from New to Accepted

It's strange that the _ is failing only in that file, could you check if maybe it's missing an include file? That would be a better fix for that issue.

Actions
Copy link
 #2

Updated by delroth over 12 years ago

  • Status changed from Accepted to Questionable

I wasn't able to reproduce that locally with wx2.9.4. Could you confirm it's not an issue on your side (wx configure flags, etc.)?

Actions
Copy link
 #3

Updated by Christian.Morales.Vega over 12 years ago

I'm using the openSUSE package. Could have some error, but...
And then you have http://trac.wxwidgets.org/ticket/10005 saying you can't use _() there.
Perhaps you were using an ANSI build of wx instead of an Unicode one?

Actions
Copy link
 #4

Updated by delroth over 12 years ago

That makes sense, I did not realize this _() call was in a structure initialization context. The issue you're linking to makes it very clear that you're right.

The patch does not seem to break Windows build or Linux build with Externals wxWidgets, so go ahead and commit it (you seem to already have commit access to the project).

Actions
Copy link
 #5

Updated by rdragoon over 12 years ago

  • Status changed from Questionable to Fixed

Fixed by revision a135512f9bf0.

Actions
Copy link

Also available in: Atom PDF