Emulator Issues #6757
closed
[Pull Request] (eventually) JPeterson's Motion Plus
0%
Description
https://forums.dolphin-emu.org/Thread-to-pass-the-request-for-wiimotion?pid=298660#pid298660
Nothing has changed since the patch I posted in the linked post (yes, I'm Steel01 on the forum). So, it's still no where near review worthy. But since I didn't have the brain/will power to work on this further tonight, I'm adding this issue as Jhonn suggested. I won't be around my development machine for another few days. I expect that someone with input subsystem knowledge could clean this up (and find what I missed) in fairly short order. I do have a couple comments to add to the three I posted in that post.
I've been playing Tales of Symphonia: Dawn of the New World with my patched version for several hours and haven't had a problem with the basic wiimote controls.
I noticed when fiddling with the settings that swing always goes down and/or right, even when trying to go up and/or left. Think I broke a sign check in the merge somewhere.
All development and testing has been done on a Fedora 19 x86_64 machine. I can make no comments on how this affects a Windows build. But since no files were added or removed and I didn't see any ifdefs, I doubt it will affect any arch/platform differently.
Updated by NeoBrainX over 10 years ago
- Status changed from New to Won't fix
Yeah, we're not interested in cleaning up JP's mess.
Updated by NeoBrainX over 10 years ago
Maybe let me elaborate a bit more on this:
If anyone from the development team had been interested in cleaning up JP's patches, it would've already been done by now regardless of any merging or build issues since these are (in comparison) trivial to fix. There's no point of having this pull request in our issue tracker since it does serve no purpose for the development team and any external contributor will never come across this issue anyway.