Project

General

Profile

Actions

Emulator Issues #715

closed

[Feature Request] Selectable fog implementation

Added by zantezuken about 16 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Explanation here: http://code.google.com/p/dolphin-emu/issues/detail?
id=181 (latest posts).

Can be this feature "selectable"? Like Trilinear Filtering, etc...

Actions #1

Updated by XTra.KrazzY about 16 years ago

  • Status changed from New to Won't fix

No, it is emulated as it should look like, you may hack it out yourself.

Actions #2

Updated by zantezuken about 16 years ago

It is so hard to implement? Or what?
Oh wait... you need more complaining people, not just me?

Actions #3

Updated by sl1nk3.s about 16 years ago

why would you need to disable fog in the first place ?

Actions #4

Updated by zantezuken about 16 years ago

Explained in Issue 181.

Actions #5

Updated by dedbruzon about 16 years ago

Yeah, i think it'll be good feature - click on/off this fog! May be this thing can
boost some FPS in game?

Actions #6

Updated by solid.9 about 16 years ago

I agree with zantezuken, this feature must be selectable. This fog is really
annoying thing.

Actions #7

Updated by zantezuken about 16 years ago

Some self-explaining screens (thanks for luigi33):
Fog enabled (new revs): http://i050.radikal.ru/0903/f7/d19599aeae02.jpg
Fog disabled (old revs): http://s42.radikal.ru/i097/0903/20/52ed1a564f1f.jpg

Actions #8

Updated by Anonymous about 16 years ago

no. the idea is to emulate the gc, not provide a massive list of ugly hacks

Actions #9

Updated by sl1nk3.s about 16 years ago

However, we can see in these screens that the fog is quite glitchy, what rev was that ?
Could you provide a new screen of this place on newer revs ? (>r2599)

The issue here would not be disabling the fog but rather fixing it don't you think ?
(also, if you were wondering, the speed difference with fog disabled is almost 0)

Actions #10

Updated by marcus about 16 years ago

Yes, the fog is barely a week old, and therefore should be buggy. Give us (meaning
the people working on the fog) a few weeks and we'll clear it up. In the meantime,
if you don't wave the programming knowlege to hack it out yourself, I'll see if I
can make a patch for you.

Actions #11

Updated by zantezuken about 16 years ago

I don't bloody care about speed actually. Fog emulation atm is ugly and makes games
ugly too. While it is not emulates properly - can we, users, has any way to
temporary disable it? You always can remove - how it is? - oh yes, this "ugly
hax" (lol, Dolphin IS full of ugly hax even now) later.
Not so hard, isn't it? And many users will be grateful.

Actions #12

Updated by Anonymous about 16 years ago

fog itself is perfect and has been verified. Therefor if you see something which
looks wrong, even if it happens to have fog on screen, it's not fog's fault.

Actions #13

Updated by zantezuken about 16 years ago

Funnay, some of you says it is not good yet, some says it is perfect...

Actions #14

Updated by nakeee about 16 years ago

Ok, I'm going to run spell checker over this thread:P

Actions #15

Updated by zantezuken about 16 years ago

Make a patch instead >_>

Actions #16

Updated by marcus about 16 years ago

"some of you says it is not good yet", where "some of you" means me.

I frankly don't have a clue about the fog. I said it wasn't perfect because someone
told me it wasn't perfect a few doys ago. If it's perfect now, then making a patch
or a setting to disable it is pointless and would do no more than what gig said:
help provide a massive list of ugly hacks.

Actions #17

Updated by zantezuken about 16 years ago

Now I'm saying you it is not perfect >_>

Actions #18

Updated by marcus about 16 years ago

ok, try hacking it out and see if the errors go away.

Actions #19

Updated by nakeee about 16 years ago

  • Status changed from Won't fix to Questionable

zantezuken, is there a way to can get a screenshot that shows how that game should
really look like?

Actions #20

Updated by marcus about 16 years ago

And one with the fog enabled.

Actions #21

Updated by federelli about 16 years ago

It does seem weird that fog isn't applied over 3d, but it wouldn't be the first time
it's happened that way in a game.

Actions #22

Updated by federelli about 16 years ago

Characters seem to be affected by fog on these screenshots.

http://farm4.static.flickr.com/3294/2298088860_1a152079d7.jpg
http://www.mywii.com.au/img/game/Resident-Evil-Zero--1.jpg
http://www.mywii.com.au/img/game/Resident-Evil-Zero--2.jpg

Don't think we can get something much clearer than that to see, unless someone

Actions #23

Updated by marcus about 16 years ago

looks more like shadows to me...

Actions #24

Updated by federelli about 16 years ago

Just look at how the characters seem to have a tint of gray/green, as the background
does, whereas in Dolphin they look clean.

Actions #25

Updated by marcus about 16 years ago

Idk, that seems quite minor, and seems to have more to do with texturing than with
fog.

Actions #26

Updated by zantezuken about 16 years ago

no. the idea is to emulate the gc, not provide a massive list of ugly hacks

Ok, let's consider this as option but not as hack ;P
Config -> OpenGL Config -> [v] Fog emulation

_>

Actions #27

Updated by hrydgard about 16 years ago

  • Status changed from Questionable to Accepted

OK OK, go add that fog option whoever wants to :P

Actions #28

Updated by marcus about 16 years ago

I would if I knew wxwidgets...

Actions #29

Updated by nakeee about 16 years ago

  • Status changed from Accepted to Work started
Actions #30

Updated by sl1nk3.s about 16 years ago

  • Status changed from Work started to Fixed

Added in r2814, however we should maybe create a third tab and put all the
debugging/infos and dump stuff to it, because there's too much things in Advanced :/

Actions #31

Updated by zantezuken almost 16 years ago

This feature broken in latest revs.

Actions #32

Updated by marcus almost 16 years ago

Yeah, we've been having a bit of a problem with the XFB ever since r3545.

Can you test and see if that rev causes it?

Actions #33

Updated by zantezuken almost 16 years ago

It is broken in r3521 too.

Actions #34

Updated by marcus almost 16 years ago

Ok, glad that commit didn't break any more stuff.

I guess that now you open a new issue and try to find the exact revision that caused
the problem.

Actions

Also available in: Atom PDF