Emulator

I already cleared most keys but haven't cleared all and I wouldn't worry about it. But I'm going to clear them all now...

I sometime toggle background input on and off but doesn't seem to make the differences between the two while anything Dolphin's in focus, so I left it as-is, whether be it on or not.

I had it on in earlier test, off later, I'll be sure to turn it back on during this test.

The save states are fixed in the DL link you provided, in both rendering on main and in separate windows. However many problem remains for all other hotkeys :P

Is the Menu Accelerators menu going to be redundant someday when all hotkeys are fixed?

Also I'm wondering if issue 8197 is considered fixed still? The background input = off doesn't seem to do the job yet...

DOLPHIN 4.0-5406-dirty (PR 2011)

====Render to Main Window====

Menu Accelerator: save/load state

Run game - works
game fullscreen - nothing happening

Hotkey: save/load state

Run game - works (was broken)
game fullscreen - works (was broken)

====Render in separate window====

Menu Accelerator: save/load state

Run game - nothing happening
game fullscreen - nothing happening

Hotkey: save/load state

Run game - works
game fullscreen - works

Just discovered that when loading a save state using the hotkey from Menu Accelerators menu, it will CRASH instead of "nothing happening" unlike saving a save state. (On both Dolphin 4.0-5414 and PR 2011)

tested on 4.0-5422

====Render to Main Window====

Hotkey: Freelook (all keys concerning to it)

Run game - works
game fullscreen - works

====Render in separate window====

Hotkey: Freelook (all keys concerning to it)

Run game - nothing happening (also can't test freelook's speed/reset)
game fullscreen - nothing happening (also can't test freelook's speed/reset)

Mouse for freelook will work BTW.

Freelook hotkeys from Menu Accelerators are not working.

====Render to Main Window====

Change Disk

The 'Change Disk' behaves the same as 'Open'. (OK except for game list)

Reset

Run game - nothing happening
game fullscreen - nothing happening

Frame Advance

Run game - nothing happening
game fullscreen - nothing happening

====Render in separate window====

Change Disk

The 'Change Disk' behaves the same as 'Open'. (shouldn't be happening?)

Reset

Run game - works (Only for GCN?)
game fullscreen - works (Only for GCN?)

Frame Advance

Run game - works
game fullscreen - works

====General====

Refresh List

Nothing happening (even at least running a game in both Render to Main and in separate windows)

Recording (all keys concerning to it), Read Only, Volume

Nothing happening or just I don't understand what to do with it?
Wasn't able to test volume +/- and toggle mute because I'm deaf.

Exit

Nothing happening

'Connect Wiimote #' and balance Board hotkeys work, but will CRASH if running any GameCube games.

Whew, that is all out there, hopefully.

Haven't tested hotkeys from Menu Accelerators.

Adding to this:

• The freelook hotkeys seems to work sporadically if you mash the keys repeatedly.

• The checkbox "Iterative Input" won't stay checked after reopening the hotkey window. Would be nice with some tooltips as well as the purpose isn't obvious.

• I can't see some of the keys due to my vertical screen resolution being to small. Any possibility of a scroll bar?

Tested this on the PR2011 version

I still have problems with the freelook keys. When rendering in seperate window, the keys only sporadically work (maybe once every twenty presses when mashing)

Turning off the framelimiter seems to fix this bug, as every keypress now works.

Other info:

• Trying this in Luigi's Mansion
• Running win7, nvidia
• Both OGL and D3D has the same issues.

supernerd, I have made an update for the freelook keys. Let me know if it is now working as expected. The test build is at the same link:

http://dl.dolphin-emu.org/prs/pr-2011-dolphin-latest-x64.7z

The freelook move keys now work, but the behaviour for the freelook reset and change speed has not changed.

4.0-5710-dirty

We're almost there.

The only broken hotkeys are Refresh List, Open (while gamelist, not running any game), Exit, and Freelook speed/reset.

The Change Disk will work while game is running, which is okay (unlike hotkey for "Open" which it shouldn't be happening), but doing so before going fullscreen will also cause window to stuck after restored (see issue 8198). It can also replicate another window every time that hotkey is pressed.

Neither Open and Change Disk hotkeys still working on the game list (game not running). Is that by design or it should work as expected?

Only tangentially related to this issue, but can you explain why we now have both hotkeys and menu accelerators?
If they serve different purposes, why are there so much overlap?

supernerd, have now applied the same fix to the reset and change speed freelook keys. Please test it at the same link as the above.

The reason why the hotkeys and menu accelerators have overlap is because of my own laziness to remove the overlap. Hotkeys use the joystick input system on the operating system, whilst the menu accelerators are managed by wx (the GUI used in Dolphin) and wx has no support for game controllers. Additionally, some operations like File - Open and Start Game only work from the menu accelerator. I left them both in to give the most flexibility to the user to pick which method they would like to use - it is becoming clear that this was not a good move and it is a cause of confusion. You are not the first person to ask this question. We are planning on removing the overlap in a follow-up PR.

rukariosake, yes, the Open hotkey does not work on the game list. This is broken by design. We want to remove the Open hotkey in the future.

Thanks skidau, works now. Small complaint though: The freelook is now very sensitive, and only three speeds are useful. Maybe in a future PR someone can change the speed increment.

And make an enhancement issue report for it too, maybe?

All we need to do is to remove some hotkeys from Hotkey Setting that are currently broken, then we'll be done with Hotkey Setting, I think. They will be in Menu Accelerators. We should also make sure the hotkeys in Menu Accelerators are working as expected and remove alot of things from there too if needed.

Then this issue can be closed.

rukario, I have removed the Open and Refresh List hotkeys in the latest PR2011. Were there any others that should be removed?

@supernerd: AFAIK the checkbox "Iterative Input" shouldn't stay checked after closing the hotkey window, hopefully it'll make sense to you as to why once I explain what that option does:

With iterative input checked, once you click on a function to set a hotkey for it, it'll start a sequence. As soon as you press a key/button and it gets assigned, it'll jump to the next function for you to assign a key to, and it'll keep going until the sequence is done. Sort of like how VBA-M and Snes9x (and other emus like DeSmuME) behave by default when assigning keys.

Imagine if this option stayed on and then when you came back later to assign just one key, it moves on to ask for the next key and you don't even notice and end up reassigning a whole bunch of keys. No bueno.

@karasuh: OK, thanks. That makes sense in hindsight, but from the name I thought it was something like holding the button would repeat it. That's why I mentioned tooltips. Anyway, thanks.

4.0-5738-dirty

@skidau - There are few I could see that should be removed:

Change Disk - It's mostly the same as "Open" hotkey, only except that it can be opened while game is running. I think it's best have it removed along with Open hotkey and have it available in the Key Shortcuts. It will no longer trigger issue 8198 if removed, which is good.

Exit - Currently broken, but should be removed anyway. The "Stop" hotkey will do exactly the same thing, so...

Stop - I could see no reason to end the game emulation with a button on gamepad. Exit/Stop hotkey can be easily pressed by accident. I doubt there will be any users who would like to have this hotkey set up on their controller. Key Shortcut or window's "X" button will do just fine. I'd removed "Stop" too, but I don't want to become responsibility for the removal of it if there is any complaint.

That's pretty much all there is, at least for Hotkey Settings.

I haven't tested all keys under Key Shortcuts yet.

The Key Shortcuts are going to stay in Dolphin as certain OSX system keys will trigger if they are mapped to hotkeys. Dolphin overrides the system key if they have been mapped as Key Shortcuts, preventing the issue. As you've noticed, I have renamed the Menu Accelerators to Key Shortcuts in hope that the command is a bit more understandable.

I have now also removed the Change Disc and Exit hotkeys in the latest PR2011: https://github.com/dolphin-emu/dolphin/pull/2011

Let me know if the fix works for you by testing it out here:
http://dl.dolphin-emu.org/prs/pr-2011-dolphin-latest-x64.7z

If everything works here, I am looking to get this PR merged and this issue closed.

4.0-5752-dirty and 4.0-5760-dirty (Key Shortcut)

So far no groundbreaking problem with hotkeys within Hotkey Settings, except that some are too sensitive (freelook speed), others felt too unresponsive (depth/convergence that even require hundred's of presses to make small difference). I/someone else will probably make a new follow-up issue report for them later. I have not tested save/load states with number greater than 1 and have not tested Volume +/-/mute.

None in the Key Shortcuts work with game running while rendering in seperate window or in fullscreen. But some seem to work with Render to Main Window.

Is it just on my end?

Well, if you'd like, we can merge and close this issue for now and start fresh with another issue report specifically for Key Shortcuts.

Currently broken Key Shortcuts (Render to Main Window only):
-Play Recording
-Toggle Internal Resolution
-Toggle Aspect Ratio
-Toggle EFB Copies
-Toggle Fog
-Toggle Frame Limit
-Decrease/Increase Frame Limit
-Freelook

Can't test:
-Volume +/-/mute
-Freelook speed/reset (freelook are broken)
-Increase/Decrease Depth/Convergence (Only for Exclusive fullscreen)

No, it was not just your end. I have updated the PR with the fix for the Key Shortcuts so that they work again. Please test and confirm that it fixes the problem.

Is the download link supposed to be promptly up to date or is there any sort of waiting time for it to update? It seems to stay on 4.0-5760-dirty.

Nevermind! It's on same version, different PR changes.

Everything seems to work OK! You're really awesome.

Do you want to do something with sensitivity hotkeys before closing this issue?

Particularly that freelook speed being too sensitive and depth/convergence being too insignificant.

Switch them the other way then we'll be happy.

rukario, In the latest version of PR2011, I have slowed down the free-look keys and have allowed the depth/convergence keys to be held down. Let me know if the speed feels right. Thanks for testing.

Freelook speed and Depth feels just right! However Convergence feels slow.

3D Depth only took 3 seconds to max out, meanwhile Convergence took 14 seconds.

I have now updated PR2011 and made convergence the same speed as depth. Let me know if it is ok now.

I'm getting a crash on launch with the test build of PR 2011.

YES! It's perfect!

OrBlob, what OS are you using and is it crashing as soon as you start up Dolphin? Do you have any gamepads connected?

Windows 7 x64, yes and yes.

Just disconnected my gamepad and tried again, still crashed.

OrBlob, would you please create a zip file of the Config folder that is found under Documents\Dolphin Emulator\ and upload it somewhere?

http://www.mediafire.com/download/4le8dy4h8ra3bgb/Config.zip

I just pasted in a mediafire link, but the comment disappeared. Is it a blocked site, or something? If so, what's a good alternative?

OrBlob, thanks for testing and responsiveness. I have updated the latest PR2011 with a fix for the issue that you saw where the default hotkeys were getting loaded. Let me know if the test build now works on your set-up.

No idea why your comment disappeared. I was able to read it before it did though, so no worries there. I was able to download the file from your mediafire link fine.

Working great now, thanks for the fix!