Emulator

please link to the actual version of dolphin you're using, and give the "uitzonderingsmarge" for that version.
or give a dump.

Hi hodisgoverment,

I am using master build 4.0-5441 from this site (https://nl.dolphin-emu.org/download/?cr=nl), tested this also on 4.0-5432 and 4.0-5429 the issues seems on every master build

As for the dump where can i find it ? I did some more tests and get this:

I deleted all settings i made in dolphin, fired up dolphin and went to the controller option. I connected my controller and selected it, tried to fire up a game and got this.

Probleemhandtekening:
Gebeurtenisnaam van probleem: APPCRASH
Naam van de toepassing: Dolphin.exe
Versie van toepassing: 0.0.0.0
Tijdstempel van toepassing: 54da7cfa
Naam van foutmodule: KERNELBASE.dll
Versie van foutmodule: 6.3.9600.17415
Tijdstempel van foutmodule: 54505737
Uitzonderingscode: c0000002
Uitzonderingsmarge: 0000000000008b9c
Versie van besturingssysteem: 6.3.9600.2.0.0.256.4
Landinstelling-id: 1043
Aanvullende informatie 1: 2a93
Aanvullende informatie 2: 2a93df4f2feda6f8e472b62bff4adb0e
Aanvullende informatie 3: d53f
Aanvullende informatie 4: d53f6198703287d63d7de7e8f3c24271

Lees de onlineprivacyverklaring:
http://go.microsoft.com/fwlink/?linkid=280262

Als de onlineprivacyverklaring niet beschikbaar is, lees dan onze offlineprivacyverklaring:
C:\Windows\system32\nl-NL\erofflps.txt

Now i fired up dolphin, again with my controller turned off. Turned it on when dolphin was loaded, again went to the Controllers -> Config -> Refresh because otherwise my controller does not work. Tried to fire up a game and got this

Probleemhandtekening:
Gebeurtenisnaam van probleem: APPCRASH
Naam van de toepassing: Dolphin.exe
Versie van toepassing: 0.0.0.0
Tijdstempel van toepassing: 54da7cfa
Naam van foutmodule: Dolphin.exe
Versie van foutmodule: 0.0.0.0
Tijdstempel van foutmodule: 54da7cfa
Uitzonderingscode: c0000005
Uitzonderingsmarge: 00000000004ab68d
Versie van besturingssysteem: 6.3.9600.2.0.0.256.4
Landinstelling-id: 1043
Aanvullende informatie 1: 8331
Aanvullende informatie 2: 8331dd44caa25aa9b9b46bf29b669a55
Aanvullende informatie 3: fa92
Aanvullende informatie 4: fa920d87bbc05b4b47a5c6faa9ee1e03

Lees de onlineprivacyverklaring:
http://go.microsoft.com/fwlink/?linkid=280262

Als de onlineprivacyverklaring niet beschikbaar is, lees dan onze offlineprivacyverklaring:
C:\Windows\system32\nl-NL\erofflps.txt

Now these tests are on the latest dolphin master build 4.0.5441, i got the same results on previouse builds

So, I think the error is in
long double __cdecl ciface::ExpressionParser::ControlExpression::GetValue(ciface::ExpressionParser::ControlExpression *this)
but would like a dump to see what's going on better.

Make a dump and upload it to an external site.
Instructions:
https://forums.dolphin-emu.org/Thread-dolphin-crashes-after-10-15-minutes-due-to-xaudio2-7-dll-unloaded?pid=296049#pid296049

Here is a dump of the apprash, i can produce more if needed.

http://www41.zippyshare.com/v/vBf0UATm/file.html

Does it happen with this build?
http://dl.dolphin-emu.org/builds/dolphin-master-4.0-5323-x64.7z

No it does not. When my controller is off and i turn it on it sees my controller directly with this build. This is what i did not understand why it got changed in the recent builds. I don't need to refresh my controller in this build to get it working and this build does work without any error. I tried it many times and works as intended

caused by the hotkey-on-gamepads commit

micheln, does toggling the background input checkbox make it work in the latest master?

Recent builds from your post till now, nope still the same issue. Just tested again with 4.0-5521

I have this same issue. Just thought you'd like to know it's reproducible on other systems.

One thing is weird though, even after Dolphin says it crashes, the emulation keeps going. You can still hear the game's audio and it still reacts to your button presses. O_O

I can vouch for the issue as well.

Hi, can confirm this issue in your pr (2011 5710-dirty)

For me it happens any time I press the "Refresh" button, I don't have to start the game.
This happens regardless of whether I have a controller attached, just refreshing the keyboard/mouse wil crash.
This also happens with the hotkey menu "Refresh" button.

However, during the testing of this bug, it suddenly disappeared. Nothing I do can reproduce a crash. It's perfectly stable.

The only way I get a crash now is:

• On master (5716)
• While playing a game
• Only with the Refresh button in the hotkey settings menu. The refresh button in the controller settings works.
• Sometimes, I have to press it twice to get a crash.

I don't seem to get an errorlog from master, but here is the exceptioninfo.txt from pr2011: https://gist.github.com/KriPet/f6782e50b7fc066c810f

peter, thanks for noticing that. I think 4.0-5712 might have helped with this issue. I have now updated PR2011 so that the build (same link as above) contains the fix from 4.0-5712. Would you please test the PR2011 build again?

PR2011 -5712 still crashes for me when I hit refresh while the game is open. If I do the refresh beforehand though, no crash.

BTW I'd like to add that it'd be nice to have hotplugging support behave like it did back in the builds before this hotkey change where it detected the controller on its own. Now I either have to make sure the controller is on before starting up Dolphin or I have to hit the Refresh button.

I don't think the older Dolphin builds used to be able to detect recently plugged in Xinput controllers?

I can reproduce this issue exactly as described.

4.0-5712-dirty

The refresh button still crash the Dolphin. The same button in Hotkey Settings will do the same thing as well...

Other time it doesn't crash. It's indeed random!

Does Master 4.0-5720 aa24dbc56e910ea0f04d273be25fd892b7903a76 fix this issue?

Have tested 4.0-5720 myself and it doesn't fix the issue.

I have pushed what I think is the fix for this into PR2011. Let me know if it now works.

http://dl.dolphin-emu.org/prs/pr-2011-dolphin-latest-x64.7z

That dl link doesn't seem up to date... It's still on 4.0-5712-dirty.

Thanks for letting me know. I have refreshed the buildbot and verified that the link now contains the right version to test. Sorry for the missed update.

4.0-5728-dirty

No more crash in Controller Settings as long as no more than one gamecube controllers are enabled.

It seems that it will still crash even when trying to disable port 1 then enable another port or in Wiimote config.

@rukarios: Yes it could detect controllers when you plugged them in. There was no need to hit refresh.

@skidau: PR2011 -5734 is behaving the same as PR2011 -5712. No longer crashes if I hit refresh before I boot up the game, but if I hit refresh while the game is already running, it'll crash.

Also if I hit refresh second time (even while I haven't booted up the game yet), it'll crash. Not sure if the PR2011 dirty build based on -5712 did that as I no longer have access to it through your link.

The latest build of PR2011 should now fix this. I had to make the game pause while the configuration panel was open and changed how the GUI thread interacts with the CPU thread.

Let me know if it works for you.

http://dl.dolphin-emu.org/prs/pr-2011-dolphin-latest-x64.7z

Still crashing for me

seems to crash a lot less for me.

I mean it will crash only if I press Refresh button from different places like crazy.

I doubt anyone will do that anyway!

I have fixed the occasional crash. I think it occurred if a GameCube game is started and stopped followed by going into the Emulated Wiimote configuration and pressing the Refresh button.

RachelB gave me a tip which means that this PR won't pause the game while the controls are being configured anymore.

The 2011 PR should fix this issue.

Haven't gotten it to crash yet, LGTM. Thanks!

Now if you can make it so I have proper hotplugging again (i.e. not having to press Refresh), I would love you long time.